fix(wasm): remove type defs for ArrayExpressionElement and Elision#6683
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 20, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 19, 2024
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Oct 19, 2024
e1c7f40 to
af4c74e
Compare
8938d54 to
a798ae6
Compare
ArrayExpressionElementArrayExpressionElement and Elision
a798ae6 to
13f22eb
Compare
Member
Author
|
@ottomated This is the most substantial change in this stack of PRs. The change is correct, but implementation is maybe a bit hacky. You may see a better way to achieve this. |
CodSpeed Performance ReportMerging #6683 will not alter performanceComparing Summary
|
This was referenced Oct 19, 2024
ottomated
approved these changes
Oct 19, 2024
af4c74e to
e4e1deb
Compare
13f22eb to
e865bb8
Compare
e865bb8 to
0234904
Compare
0234904 to
ca8b12c
Compare
#6683) Follow-on after #6404. `ArrayExpressionElement` and `Elision` are not used in the TS types, because `ArrayExpression` has an override for the field it uses. https://github.com/oxc-project/oxc/blob/002289b4b1b0d6fac080c4b12f4939c8f455272f/crates/oxc_ast/src/ast/js.rs#L293-L302 Prevent these TS type defs being emitted by introducing a new `#[estree(custom_ts_def)]` attr, to go with `#[estree(custom_serialize)]`.
ca8b12c to
53049fe
Compare
Contributor
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-on after #6404.
ArrayExpressionElementandElisionare not used in the TS types, becauseArrayExpressionhas an override for the field it uses.oxc/crates/oxc_ast/src/ast/js.rs
Lines 293 to 302 in 002289b
Prevent these TS type defs being emitted by introducing a new
#[estree(custom_ts_def)]attr, to go with#[estree(custom_serialize)].