refactor(ast_tools): move #[allow] attrs to top of generated files#6679
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 19, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 19, 2024
Member
Author
This was referenced Oct 19, 2024
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
github-actions
bot
added
A-ast
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files
branch
from
467ebec to
cb29f0d
Compare
CodSpeed Performance ReportMerging #6679 will not alter performanceComparing Summary
|
This was referenced Oct 19, 2024
ottomated
approved these changes
Oct 19, 2024
Contributor
ottomated
left a comment
ottomated
left a comment
There was a problem hiding this comment.
Was wondering if this was possible, thanks
Contributor
Merge activity
|
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_shorten_code
branch
from
66ed87a to
f0dd19a
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files
branch
from
cb29f0d to
9ba2b0e
Compare
Base automatically changed from
10-19-refactor_ast_tools_shorten_code
to
main
October 19, 2024 20:02
graphite-app
bot
deleted the
10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #6404. Shorten generated code for
impl Serializeby moving#[allow]attrs to top of file.