refactor(ast_tools): shorten generated code by avoiding ref in matches#6675
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 19, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This was referenced Oct 19, 2024
github-actions
bot
added
A-ast
overlookmotel
force-pushed
the
10-19-style_ast_tools_do_not_use_ref_in_matches
branch
from
a2611e1 to
33d2557
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
branch
from
7779992 to
5f35384
Compare
overlookmotel
force-pushed
the
10-19-style_ast_tools_do_not_use_ref_in_matches
branch
from
33d2557 to
002289b
Compare
Base automatically changed from
10-19-style_ast_tools_do_not_use_ref_in_matches
to
main
October 19, 2024 09:01
CodSpeed Performance ReportMerging #6675 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
branch
from
5f35384 to
6e356e9
Compare
This was referenced Oct 19, 2024
ottomated
approved these changes
Oct 19, 2024
Contributor
ottomated
left a comment
ottomated
left a comment
There was a problem hiding this comment.
If this works, it's fine with me—this existed to match serde's output as close as possible
overlookmotel
added
the
0-merge
Graphite App
Contributor
Merge activity
|
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
branch
from
6e356e9 to
11458a5
Compare
graphite-app
bot
deleted the
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #6404.
Shorten generated code for deriving
ESTreeby avoidingrefin matches.