Skip to content

Comments

style(ast_tools): do not use ref in matches#6674

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-19-style_ast_tools_do_not_use_ref_in_matches
Oct 19, 2024
Merged

style(ast_tools): do not use ref in matches#6674
graphite-app[bot] merged 1 commit intomainfrom
10-19-style_ast_tools_do_not_use_ref_in_matches

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 19, 2024

Style nit.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 19, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 08:46
@overlookmotel
Copy link
Member Author

@ottomated FYI: Of course there's nothing wrong with using ref in matches, it's just not our "house style".

@overlookmotel
Copy link
Member Author

Trivial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 19, 2024
@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_fix_formatting branch from 2423655 to a47b38f Compare October 19, 2024 08:50
Copy link
Member Author

overlookmotel commented Oct 19, 2024

Merge activity

  • Oct 19, 4:51 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 19, 4:51 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 19, 5:01 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_do_not_use_ref_in_matches branch from a2611e1 to 33d2557 Compare October 19, 2024 08:53
Base automatically changed from 10-19-style_ast_tools_fix_formatting to main October 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant