Skip to content

refactor(allocator): fix equatable_if_let clippy warnings#21234

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_allocator_fix_equatable_if_let_clippy_warnings
Apr 9, 2026
Merged

refactor(allocator): fix equatable_if_let clippy warnings#21234
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_allocator_fix_equatable_if_let_clippy_warnings

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026

Continuation of #21231.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the clippy::equatable_if_let expectation from bumpalo_alloc.rs by refactoring realloc’s in-place grow/shrink checks into Clippy-approved idioms.

Changes:

  • Drop clippy::equatable_if_let from the crate-level #![expect(...)] list.
  • Replace if let Ok(()) = ... with .is_ok() for grow_in_place / shrink_in_place results in Alloc::realloc.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 9, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-09-refactor_allocator_fix_equatable_if_let_clippy_warnings (55e4d4d) with om/04-09-refactor_allocator_fix_collapsible_if_clippy_warnings (8ef946e)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on om/04-09-refactor_allocator_fix_collapsible_if_clippy_warnings (8ef946e) during the generation of this report, so 4ea66df was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 9, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the om/04-09-refactor_allocator_fix_collapsible_if_clippy_warnings branch from 7d7e1d8 to 8ef946e Compare April 9, 2026 13:15
@graphite-app graphite-app bot force-pushed the om/04-09-refactor_allocator_fix_equatable_if_let_clippy_warnings branch from b1e0324 to 55e4d4d Compare April 9, 2026 13:15
Base automatically changed from om/04-09-refactor_allocator_fix_collapsible_if_clippy_warnings to main April 9, 2026 13:22
@graphite-app graphite-app bot merged commit 55e4d4d into main Apr 9, 2026
37 checks passed
@graphite-app graphite-app bot deleted the om/04-09-refactor_allocator_fix_equatable_if_let_clippy_warnings branch April 9, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants