refactor(allocator): fix legacy_numeric_constants clippy warnings#21231
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Conversation
Member
Author
This was referenced Apr 9, 2026
github-actions
bot
added
A-allocator
This was referenced Apr 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the clippy::legacy_numeric_constants expectation by eliminating the now-unneeded core::usize import in bumpalo_alloc.rs.
Changes:
- Dropped
clippy::legacy_numeric_constantsfrom the crate-level#![expect(...)]list. - Removed
use core::usize;(no longer used).
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Merge activity
|
…21231) Same as stack starting at #21210. `bumpalo_alloc.rs` was copied directly from `bumpalo`. `bumpalo` supports much older Rust versions than Oxc does, so uses patterns which are flagged by Clippy in more recent versions. #20963 silenced these clippy errors/warnings with a large `#[expect]` block at the top of the file. This stack of PRs fixes these warnings and removes the `#[expect(clippy:...)]` comments. All PRs in this stack were generated by Claude. I had him split them into 1 PR per clippy rule so that I could review each in isolation - some of the changes, especially around pointers, are quite subtlle.
graphite-app
bot
force-pushed
the
om/04-09-refactor_allocator_fix_legacy_numeric_constants_clippy_warnings
branch
from
a440ebf to
3c9088c
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
) Continuation of #21231.
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
Continuation of #21231. Also remove a pointless branch condition.
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
Continuation of #21231.
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
Continuation of #21231.
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
Continuation of #21231.
graphite-app
bot
deleted the
om/04-09-refactor_allocator_fix_legacy_numeric_constants_clippy_warnings
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as stack starting at #21210.
bumpalo_alloc.rswas copied directly frombumpalo.bumpalosupports much older Rust versions than Oxc does, so uses patterns which are flagged by Clippy in more recent versions. #20963 silenced these clippy errors/warnings with a large#[expect]block at the top of the file.This stack of PRs fixes these warnings and removes the
#[expect(clippy:...)]comments. All PRs in this stack were generated by Claude. I had him split them into 1 PR per clippy rule so that I could review each in isolation - some of the changes, especially around pointers, are quite subtlle.