refactor(allocator): fix collapsible_if clippy warnings

[overlookmotel]

Continuation of #21231.

Also remove a pointless branch condition.

[overlookmotel]

• refactor(allocator): fix missing_safety_doc clippy warnings #21239
• refactor(allocator): fix unsafe_op_in_unsafe_fn clippy warnings #21238
• refactor(allocator): fix unused_self clippy warnings #21237
• refactor(allocator): fix unnecessary_literal_bound clippy warnings #21236
• refactor(allocator): fix redundant_closure_for_method_calls clippy warnings #21235
• refactor(allocator): fix equatable_if_let clippy warnings #21234
• refactor(allocator): fix collapsible_if clippy warnings #21233 👈 (View in Graphite)
• refactor(allocator): fix uninlined_format_args clippy warnings #21232
• refactor(allocator): fix legacy_numeric_constants clippy warnings #21231
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Refactors the Alloc::realloc implementation in bumpalo_alloc.rs to address Clippy’s collapsible_if warning(s) as part of the ongoing effort (from #21231) to remove broad #[expect(clippy::...)] suppressions inherited from upstream bumpalo.

Changes:

• Removes clippy::collapsible_if from the file-level #![expect(...)] list.
• Simplifies realloc’s size-compare branching by replacing a redundant else if new_size < old_size with else.
• Adds a local #[expect(clippy::collapsible_else_if)] to silence the new warning introduced by the refactor.

[codspeed-hq]

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing om/04-09-refactor_allocator_fix_collapsible_if_clippy_warnings (8ef946e) with main (36cdc31)²}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (e011bb7) during the generation of this report, so 36cdc31 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[graphite-app]

Merge activity

• Apr 9, 1:10 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Apr 9, 1:22 PM UTC: Merged by the Graphite merge queue.