feat(oxfmt): add node version hint for ts config import failures by camc314 · Pull Request #21046 · oxc-project/oxc

camc314 · 2026-04-04T16:24:39Z

camc314 · 2026-04-04T16:24:53Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Adds improved diagnostics when loading TS-based config files fails due to unsupported Node.js TypeScript module loading, by detecting .ts/.mts/.cts specifiers and appending a Node version requirement hint.

Changes:

Introduces src-js/cli/node_version.ts helper utilities for TS-specifier detection and error hint generation.
Wraps loadJsConfig() dynamic import in a try/catch to surface a more actionable Node version hint on specific failures.
Adds Vitest coverage for the new helper behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
apps/oxfmt/src-js/cli/node_version.ts	Adds Node/TS support range constant + helper functions for generating a Node version hint message.
apps/oxfmt/src-js/cli/js_config.ts	Catches dynamic import failures and rethrows with the Node version hint when applicable.
apps/oxfmt/test/cli/js_config/node_version.test.ts	Unit tests for TS specifier detection and hint string generation.

apps/oxfmt/src-js/cli/js_config.ts

apps/oxfmt/src-js/cli/node_version.ts

leaysgur

Thank you!

I'll merge this now and address the minor adjustments in a follow-up PR.

graphite-app · 2026-04-06T02:27:19Z

Merge activity

Apr 6, 2:27 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Apr 6, 2:31 AM UTC: Merged by the Graphite merge queue.

) Refs: #21032

# Oxlint ### 💥 BREAKING CHANGES - 22ce6af oxlint/lsp: [**BREAKING**] Show/fix safe suggestions by default (#19816) (Sysix) ### 🚀 Features - 7a7b7b8 oxlint/lsp: Add source.fixAllDangerous.oxc code action kind (#20526) (bab) - 9cfe57e linter/unicorn: Implement prefer-import-meta-properties rule (#20662) (Irfan - ئىرفان) - 1edb391 linter/eslint: Implement `no-restricted-exports` rule (#20592) (Nicolas Le Cam) - 0f12bcd linter/react: Implement `hook-use-state` rule (#20986) (Khaled Labeb) - 1513a9f oxlint/lsp: Show note field for lsp diagnostic (#20983) (Sysix) - 7fdf722 linter/unicorn: Implement `no-useless-iterator-to-array` rule (#20945) (Mikhail Baev) - 39c8f2c linter/jest: Implement padding-around-after-all-blocks (#21034) (Sapphire) - ac39e51 linter/eslint-vitest-plugin: Prefer importing vitest globals (#20960) (Said Atrahouch) - 0b84de1 oxlint: Support allow option for prefer-promise-reject-errors (#20934) (camc314) - 23db851 linter/consistent-return: Move rule from nursery to suspicious (#20920) (camc314) - 9a27e32 linter/no-unnecessary-type-conversion: Move rule from nursery to suspicious (#20919) (camc314) - 1ca7b58 linter/dot-notation: Move rule from nursery to style (#20918) (camc314) - 73ba81a linter/consistent-type-exports: Move rule from nursery to style (#20917) (camc314) - b9199b1 linter/unicorn: Implement switch-case-break-position (#20872) (Mikhail Baev) - 3435ff8 linter: Implements `prefer-snapshot-hint` rule in Jest and Vitest (#20870) (Said Atrahouch) - 98510d2 linter: Implement react/prefer-function-component (#19652) (Connor Shea) - 871f9d9 linter: Implement no-useless-assignment (#15466) (Zhaoting Zhou) - 0f01fbd linter: Implement eslint/object-shorthand (#17688) (yue) ### 🐛 Bug Fixes - dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya kawaguchi) - 9bc77dd linter/no-unused-private-class-members: False positive with await expr (#21067) (camc314) - 60a57cd linter/const-comparisons: Detect equality contradictions (#21065) (camc314) - 2bb2be2 linter/no-array-index-key: False positive when index is passed as function argument (#21012) (bab) - 6492953 linter/no-this-in-sfc: Only flag `this` used as member expression object (#20961) (bab) - 9446dcc oxlint/lsp: Skip `node_modules` in oxlint config walker (#21004) (copilot-swe-agent) - af89923 linter/no-namespace: Support glob pattern matching against basename (#21031) (bab) - 64a1a7e oxlint: Don't search for nested config outside base config (#21051) (Sysix) - 3b953bc linter/button-has-type: Ignore `document.createElement` calls (#21008) (Said Atrahouch) - 8c36070 linter/unicorn: Add support for `Array.from()` for `prefer-set-size` rule (#21016) (Mikhail Baev) - c1a48f0 linter: Detect vitest import from vite-plus/test (#20976) (Said Atrahouch) - 5c32fd1 lsp: Prevent corrupted autofix output from overlapping text edits (#19793) (Peter Wagenet) - ca79960 linter/no-array-index-key: Move span to `key` property (#20947) (camc314) - 2098274 linter: Add suggestion for `jest/prefer-equality-matcher` (#20925) (eryue0220) - 6eb77ec linter: Allow default-import barrels in import/named (#20757) (Bazyli Brzóska) - 9c218ef linter/eslint-vitest-plugin: Remove pending fix status for require-local-test-context-for-concurrent-snapshot (#20890) (Said Atrahouch) ### ⚡ Performance - fb52383 napi/parser, linter/plugins: Clear buffers and source texts earlier (#21025) (overlookmotel) - 3b7dec4 napi/parser, linter/plugins: Use `utf8Slice` for decoding UTF-8 strings (#21022) (overlookmotel) - 012c924 napi/parser, linter/plugins: Speed up decoding strings in raw transfer (#21021) (overlookmotel) - 55e1e9b napi/parser, linter/plugins: Initialize vars as 0 (#21020) (overlookmotel) - c25ef02 napi/parser, linter/plugins: Simplify branch condition in `deserializeStr` (#21019) (overlookmotel) - 9f494c3 napi/parser, linter/plugins: Raw transfer use `String.fromCharCode` in string decoding (#21018) (overlookmotel) - 0503a78 napi/parser, linter/plugins: Faster deserialization of `raw` fields (#20923) (overlookmotel) - a24f75e napi/parser: Optimize string deserialization for non-ASCII sources (#20834) (Joshua Tuddenham) ### 📚 Documentation - af72b80 oxlint: Fix typo for --tsconfig (#20889) (leaysgur) - 70c53b1 linter: Highlight that tsconfig is not respected in type aware linting (#20884) (camc314) # Oxfmt ### 🚀 Features - 35cf6e8 oxfmt: Add node version hint for ts config import failures (#21046) (camc314) ### 🐛 Bug Fixes - dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya kawaguchi) - 9d45511 oxfmt: Propagate file write errors instead of panicking (#20997) (leaysgur) - 139ddd9 formatter: Handle leading comment after array elision (#20987) (leaysgur) - 4216380 oxfmt: Support `.editorconfig` `tab_width` fallback (#20988) (leaysgur) - d10df39 formatter: Resolve pending space in fits measurer before expanded-mode early exit (#20954) (Dunqing) - f9ef1bd formatter: Avoid breaking after `=>` when arrow body has JSDoc type cast (#20857) (bab) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

camc314 marked this pull request as ready for review April 4, 2026 16:24

camc314 requested a review from leaysgur as a code owner April 4, 2026 16:24

Copilot AI review requested due to automatic review settings April 4, 2026 16:24

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Apr 4, 2026

Copilot started reviewing on behalf of camc314 April 4, 2026 16:25 View session

camc314 assigned leaysgur Apr 4, 2026

Copilot AI reviewed Apr 4, 2026

View reviewed changes

apps/oxfmt/src-js/cli/js_config.ts Show resolved Hide resolved

apps/oxfmt/src-js/cli/node_version.ts Show resolved Hide resolved

leaysgur mentioned this pull request Apr 6, 2026

refactor(oxfmt): Arrange cli/js_config dir #21078

Merged

leaysgur approved these changes Apr 6, 2026

View reviewed changes

leaysgur added the 0-merge Merge with Graphite Merge Queue label Apr 6, 2026

feat(oxfmt): add node version hint for ts config import failures (#21046

35cf6e8

) Refs: #21032

graphite-app bot force-pushed the c/feat-oxfmt-ts-config-node-hint branch from b5ec973 to 35cf6e8 Compare April 6, 2026 02:28

graphite-app bot merged commit 35cf6e8 into main Apr 6, 2026
24 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 6, 2026

graphite-app bot deleted the c/feat-oxfmt-ts-config-node-hint branch April 6, 2026 02:31

Boshen mentioned this pull request Apr 6, 2026

release(apps): oxlint v1.59.0 && oxfmt v0.44.0 #21085

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(oxfmt): add node version hint for ts config import failures#21046

feat(oxfmt): add node version hint for ts config import failures#21046
graphite-app[bot] merged 1 commit intomainfrom
c/feat-oxfmt-ts-config-node-hint

camc314 commented Apr 4, 2026 •

edited

Loading

Uh oh!

camc314 commented Apr 4, 2026 •

edited by leaysgur

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Uh oh!

graphite-app bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Apr 4, 2026 • edited by leaysgur Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Apr 4, 2026 •

edited

Loading

camc314 commented Apr 4, 2026 •

edited by leaysgur

Loading

graphite-app bot commented Apr 6, 2026 •

edited

Loading