feat(linter/unicorn): implement no-useless-iterator-to-array rule

[baevm]

this PR implements unicorn/no-useless-iterator-to-array rule, issue #684

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks¹

---

_{Comparing baevm:unicorn/no_useless_iterator_to_array (774d420) with main (af89923)}

Footnotes

1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[baevm]

@codex code review

[chatgpt-codex-connector]

To use Codex here, create an environment for this repo.

[Copilot]

Pull request overview

Implements the unicorn/no-useless-iterator-to-array lint rule in oxc_linter, adding diagnostics for unnecessary Iterator.prototype.toArray() calls in contexts that accept iterables directly.

Changes:

• Added a new Unicorn rule implementation with coverage for new expressions, static calls (e.g. Array.from, Promise.all), for…of, yield*, and spread contexts.
• Added rule tests and a new snapshot to validate diagnostics output.
• Registered the rule across the linter’s module tree and generated rule enums/runners.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/unicorn/no_useless_iterator_to_array.rs	New rule implementation + unit tests for detecting unnecessary .toArray() usage.
crates/oxc_linter/src/snapshots/unicorn_no_useless_iterator_to_array.snap	New snapshot covering diagnostics emitted by the rule tests.
crates/oxc_linter/src/rules.rs	Exposes the new Unicorn rule module.
crates/oxc_linter/src/generated/rules_enum.rs	Registers the rule in the generated rule enum, IDs, metadata wiring, and factory.
crates/oxc_linter/src/generated/rule_runner_impls.rs	Adds AST node-type wiring so the runner invokes the rule on relevant nodes.

[camc314]

Thank yoU!