feat(oxlint/lsp): show note field for lsp diagnostic by Sysix · Pull Request #20983 · oxc-project/oxc

Sysix · 2026-04-02T19:11:56Z

closes oxc-project/oxc-intellij-plugin#423

Screenshot:

Sysix · 2026-04-02T19:12:10Z

feat(oxlint/lsp): show note field for lsp diagnostic #20983 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Adds support for surfacing note content from OxcDiagnostic in oxlint’s LSP Diagnostic.message, updating LSP snapshot expectations accordingly (addresses oxc-intellij-plugin issue #423).

Changes:

Append error.note (in addition to error.help) to the generated LSP diagnostic message.
Update LSP snapshot outputs for import/no-cycle to include the new note: cycle-path details.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
apps/oxlint/src/lsp/error_with_position.rs	Concatenates `help` and new `note` fields into the LSP diagnostic message.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_ts_path_alias@deep__src__dep-a.ts.snap	Snapshot updated to expect `note:` cycle-path details in the diagnostic message.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_cross_module@dep-a.ts.snap	Snapshot updated to expect `note:` cycle-path details in the diagnostic message.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_cross_module_nested_config@dep-a.ts_folder__folder-dep-a.ts.snap	Snapshot updated to expect `note:` cycle-path details in the diagnostic message.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_cross_module_extended_config@dep-a.ts.snap	Snapshot updated to expect `note:` cycle-path details in the diagnostic message.

apps/oxlint/src/lsp/error_with_position.rs

camc314

really nice!

camc314 · 2026-04-05T13:25:01Z

Another random thought I had was that it would be very nice if we could have the same sort of "view full compiler diagnostic" like rustc has? This would be especially helpful for diagnostics with multiple spans in a bunch of different locations

camc314 · 2026-04-05T13:25:12Z

Merge activity

Apr 5, 1:25 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 5, 1:25 PM UTC: camc314 added this pull request to the Graphite merge queue.
Apr 5, 1:37 PM UTC: Merged by the Graphite merge queue.

closes oxc-project/oxc-intellij-plugin#423 Screenshot: <img width="1126" height="301" alt="grafik" src="https://github.com/user-attachments/assets/675d8088-76b3-4951-b014-24d5198755a9" />

# Oxlint ### 💥 BREAKING CHANGES - 22ce6af oxlint/lsp: [**BREAKING**] Show/fix safe suggestions by default (#19816) (Sysix) ### 🚀 Features - 7a7b7b8 oxlint/lsp: Add source.fixAllDangerous.oxc code action kind (#20526) (bab) - 9cfe57e linter/unicorn: Implement prefer-import-meta-properties rule (#20662) (Irfan - ئىرفان) - 1edb391 linter/eslint: Implement `no-restricted-exports` rule (#20592) (Nicolas Le Cam) - 0f12bcd linter/react: Implement `hook-use-state` rule (#20986) (Khaled Labeb) - 1513a9f oxlint/lsp: Show note field for lsp diagnostic (#20983) (Sysix) - 7fdf722 linter/unicorn: Implement `no-useless-iterator-to-array` rule (#20945) (Mikhail Baev) - 39c8f2c linter/jest: Implement padding-around-after-all-blocks (#21034) (Sapphire) - ac39e51 linter/eslint-vitest-plugin: Prefer importing vitest globals (#20960) (Said Atrahouch) - 0b84de1 oxlint: Support allow option for prefer-promise-reject-errors (#20934) (camc314) - 23db851 linter/consistent-return: Move rule from nursery to suspicious (#20920) (camc314) - 9a27e32 linter/no-unnecessary-type-conversion: Move rule from nursery to suspicious (#20919) (camc314) - 1ca7b58 linter/dot-notation: Move rule from nursery to style (#20918) (camc314) - 73ba81a linter/consistent-type-exports: Move rule from nursery to style (#20917) (camc314) - b9199b1 linter/unicorn: Implement switch-case-break-position (#20872) (Mikhail Baev) - 3435ff8 linter: Implements `prefer-snapshot-hint` rule in Jest and Vitest (#20870) (Said Atrahouch) - 98510d2 linter: Implement react/prefer-function-component (#19652) (Connor Shea) - 871f9d9 linter: Implement no-useless-assignment (#15466) (Zhaoting Zhou) - 0f01fbd linter: Implement eslint/object-shorthand (#17688) (yue) ### 🐛 Bug Fixes - dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya kawaguchi) - 9bc77dd linter/no-unused-private-class-members: False positive with await expr (#21067) (camc314) - 60a57cd linter/const-comparisons: Detect equality contradictions (#21065) (camc314) - 2bb2be2 linter/no-array-index-key: False positive when index is passed as function argument (#21012) (bab) - 6492953 linter/no-this-in-sfc: Only flag `this` used as member expression object (#20961) (bab) - 9446dcc oxlint/lsp: Skip `node_modules` in oxlint config walker (#21004) (copilot-swe-agent) - af89923 linter/no-namespace: Support glob pattern matching against basename (#21031) (bab) - 64a1a7e oxlint: Don't search for nested config outside base config (#21051) (Sysix) - 3b953bc linter/button-has-type: Ignore `document.createElement` calls (#21008) (Said Atrahouch) - 8c36070 linter/unicorn: Add support for `Array.from()` for `prefer-set-size` rule (#21016) (Mikhail Baev) - c1a48f0 linter: Detect vitest import from vite-plus/test (#20976) (Said Atrahouch) - 5c32fd1 lsp: Prevent corrupted autofix output from overlapping text edits (#19793) (Peter Wagenet) - ca79960 linter/no-array-index-key: Move span to `key` property (#20947) (camc314) - 2098274 linter: Add suggestion for `jest/prefer-equality-matcher` (#20925) (eryue0220) - 6eb77ec linter: Allow default-import barrels in import/named (#20757) (Bazyli Brzóska) - 9c218ef linter/eslint-vitest-plugin: Remove pending fix status for require-local-test-context-for-concurrent-snapshot (#20890) (Said Atrahouch) ### ⚡ Performance - fb52383 napi/parser, linter/plugins: Clear buffers and source texts earlier (#21025) (overlookmotel) - 3b7dec4 napi/parser, linter/plugins: Use `utf8Slice` for decoding UTF-8 strings (#21022) (overlookmotel) - 012c924 napi/parser, linter/plugins: Speed up decoding strings in raw transfer (#21021) (overlookmotel) - 55e1e9b napi/parser, linter/plugins: Initialize vars as 0 (#21020) (overlookmotel) - c25ef02 napi/parser, linter/plugins: Simplify branch condition in `deserializeStr` (#21019) (overlookmotel) - 9f494c3 napi/parser, linter/plugins: Raw transfer use `String.fromCharCode` in string decoding (#21018) (overlookmotel) - 0503a78 napi/parser, linter/plugins: Faster deserialization of `raw` fields (#20923) (overlookmotel) - a24f75e napi/parser: Optimize string deserialization for non-ASCII sources (#20834) (Joshua Tuddenham) ### 📚 Documentation - af72b80 oxlint: Fix typo for --tsconfig (#20889) (leaysgur) - 70c53b1 linter: Highlight that tsconfig is not respected in type aware linting (#20884) (camc314) # Oxfmt ### 🚀 Features - 35cf6e8 oxfmt: Add node version hint for ts config import failures (#21046) (camc314) ### 🐛 Bug Fixes - dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya kawaguchi) - 9d45511 oxfmt: Propagate file write errors instead of panicking (#20997) (leaysgur) - 139ddd9 formatter: Handle leading comment after array elision (#20987) (leaysgur) - 4216380 oxfmt: Support `.editorconfig` `tab_width` fallback (#20988) (leaysgur) - d10df39 formatter: Resolve pending space in fits measurer before expanded-mode early exit (#20954) (Dunqing) - f9ef1bd formatter: Avoid breaking after `=>` when arrow body has JSDoc type cast (#20857) (bab) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Apr 2, 2026

Sysix requested a review from Copilot April 2, 2026 19:13

Copilot started reviewing on behalf of Sysix April 2, 2026 19:13 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

apps/oxlint/src/lsp/error_with_position.rs Outdated Show resolved Hide resolved

apps/oxlint/src/lsp/error_with_position.rs Outdated Show resolved Hide resolved

Sysix force-pushed the 04-02-feat_oxlint_lsp_show_note_field_for_lsp_diagnostic branch from 82abc07 to 6627752 Compare April 2, 2026 19:29

Sysix marked this pull request as ready for review April 2, 2026 19:33

Sysix requested a review from camc314 as a code owner April 2, 2026 19:33

Sysix assigned camc314 Apr 2, 2026

camchenry approved these changes Apr 2, 2026

View reviewed changes

camc314 approved these changes Apr 5, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 5, 2026

graphite-app bot force-pushed the 04-02-feat_oxlint_lsp_show_note_field_for_lsp_diagnostic branch from 6627752 to 61af713 Compare April 5, 2026 13:30

feat(oxlint/lsp): show note field for lsp diagnostic (#20983)

1513a9f

closes oxc-project/oxc-intellij-plugin#423 Screenshot: <img width="1126" height="301" alt="grafik" src="https://github.com/user-attachments/assets/675d8088-76b3-4951-b014-24d5198755a9" />

graphite-app bot force-pushed the 04-02-feat_oxlint_lsp_show_note_field_for_lsp_diagnostic branch from 61af713 to 1513a9f Compare April 5, 2026 13:32

graphite-app bot merged commit 1513a9f into main Apr 5, 2026
23 of 24 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 5, 2026

graphite-app bot deleted the 04-02-feat_oxlint_lsp_show_note_field_for_lsp_diagnostic branch April 5, 2026 13:37

Boshen mentioned this pull request Apr 6, 2026

release(apps): oxlint v1.59.0 && oxfmt v0.44.0 #21085

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(oxlint/lsp): show note field for lsp diagnostic#20983

feat(oxlint/lsp): show note field for lsp diagnostic#20983
graphite-app[bot] merged 1 commit intomainfrom
04-02-feat_oxlint_lsp_show_note_field_for_lsp_diagnostic

Sysix commented Apr 2, 2026 •

edited

Loading

Uh oh!

Sysix commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Uh oh!

camc314 commented Apr 5, 2026

Uh oh!

camc314 commented Apr 5, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Sysix commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Apr 2, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Apr 5, 2026

Uh oh!

camc314 commented Apr 5, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sysix commented Apr 2, 2026 •

edited

Loading

camc314 commented Apr 5, 2026 •

edited by graphite-app bot

Loading