feat(linter): implement eslint/object-shorthand by yue4u · Pull Request #17688 · oxc-project/oxc

yue4u · 2026-01-06T02:15:18Z

Related: #479

This PR Implements eslint/object-shorthand

All eslint tests are ported and should pass.
Some API usage and implementation might not be in the preferred style.
Some setup code and base structure is reusing the work from #3211

…18218) Changing `run()` into `run_once()` during implementation will cause this assert to be triggered, but the message is not pointing to a clear direction. It took me a while to debug this for #17688. rebase: fix commit message typo

codspeed-hq · 2026-01-24T09:43:27Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

_{Comparing yue4u:object-shorthand (49eb9f9) with main (02f108f)}

52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

crates/oxc_linter/src/rules/eslint/object_shorthand.rs

yue4u · 2026-01-24T15:35:24Z

@camc314 Hi! On my side base features are implemented and tests are passing, please take a look when you have time and tell me if the overall direction is ok. Thank you.

crates/oxc_linter/src/rules/eslint/object_shorthand.rs

Copilot

Pull request overview

Implements the ESLint object-shorthand rule in oxc_linter, including diagnostics and auto-fixes, and wires the rule into the linter’s rule registry and snapshots.

Changes:

Added eslint/object-shorthand rule implementation with fixer support and extensive ported ESLint test cases.
Registered the new rule in the eslint module and generated rule enums/runners.
Added a new snapshot file covering expected diagnostics and fixes.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/eslint/object_shorthand.rs	New rule implementation, config parsing, fixer logic, and ported tests.
crates/oxc_linter/src/rules.rs	Exposes the new `eslint::object_shorthand` module.
crates/oxc_linter/src/generated/rules_enum.rs	Adds the rule to the generated rule enum and metadata plumbing.
crates/oxc_linter/src/generated/rule_runner_impls.rs	Registers AST node types handled by the new rule for the runner.
crates/oxc_linter/src/snapshots/eslint_object_shorthand.snap	New snapshot output for the rule’s diagnostics/fixes.

crates/oxc_linter/src/rules/eslint/object_shorthand.rs

camc314

Thank you! sorry for the delay!

# Oxlint ### 💥 BREAKING CHANGES - 22ce6af oxlint/lsp: [**BREAKING**] Show/fix safe suggestions by default (#19816) (Sysix) ### 🚀 Features - 7a7b7b8 oxlint/lsp: Add source.fixAllDangerous.oxc code action kind (#20526) (bab) - 9cfe57e linter/unicorn: Implement prefer-import-meta-properties rule (#20662) (Irfan - ئىرفان) - 1edb391 linter/eslint: Implement `no-restricted-exports` rule (#20592) (Nicolas Le Cam) - 0f12bcd linter/react: Implement `hook-use-state` rule (#20986) (Khaled Labeb) - 1513a9f oxlint/lsp: Show note field for lsp diagnostic (#20983) (Sysix) - 7fdf722 linter/unicorn: Implement `no-useless-iterator-to-array` rule (#20945) (Mikhail Baev) - 39c8f2c linter/jest: Implement padding-around-after-all-blocks (#21034) (Sapphire) - ac39e51 linter/eslint-vitest-plugin: Prefer importing vitest globals (#20960) (Said Atrahouch) - 0b84de1 oxlint: Support allow option for prefer-promise-reject-errors (#20934) (camc314) - 23db851 linter/consistent-return: Move rule from nursery to suspicious (#20920) (camc314) - 9a27e32 linter/no-unnecessary-type-conversion: Move rule from nursery to suspicious (#20919) (camc314) - 1ca7b58 linter/dot-notation: Move rule from nursery to style (#20918) (camc314) - 73ba81a linter/consistent-type-exports: Move rule from nursery to style (#20917) (camc314) - b9199b1 linter/unicorn: Implement switch-case-break-position (#20872) (Mikhail Baev) - 3435ff8 linter: Implements `prefer-snapshot-hint` rule in Jest and Vitest (#20870) (Said Atrahouch) - 98510d2 linter: Implement react/prefer-function-component (#19652) (Connor Shea) - 871f9d9 linter: Implement no-useless-assignment (#15466) (Zhaoting Zhou) - 0f01fbd linter: Implement eslint/object-shorthand (#17688) (yue) ### 🐛 Bug Fixes - dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya kawaguchi) - 9bc77dd linter/no-unused-private-class-members: False positive with await expr (#21067) (camc314) - 60a57cd linter/const-comparisons: Detect equality contradictions (#21065) (camc314) - 2bb2be2 linter/no-array-index-key: False positive when index is passed as function argument (#21012) (bab) - 6492953 linter/no-this-in-sfc: Only flag `this` used as member expression object (#20961) (bab) - 9446dcc oxlint/lsp: Skip `node_modules` in oxlint config walker (#21004) (copilot-swe-agent) - af89923 linter/no-namespace: Support glob pattern matching against basename (#21031) (bab) - 64a1a7e oxlint: Don't search for nested config outside base config (#21051) (Sysix) - 3b953bc linter/button-has-type: Ignore `document.createElement` calls (#21008) (Said Atrahouch) - 8c36070 linter/unicorn: Add support for `Array.from()` for `prefer-set-size` rule (#21016) (Mikhail Baev) - c1a48f0 linter: Detect vitest import from vite-plus/test (#20976) (Said Atrahouch) - 5c32fd1 lsp: Prevent corrupted autofix output from overlapping text edits (#19793) (Peter Wagenet) - ca79960 linter/no-array-index-key: Move span to `key` property (#20947) (camc314) - 2098274 linter: Add suggestion for `jest/prefer-equality-matcher` (#20925) (eryue0220) - 6eb77ec linter: Allow default-import barrels in import/named (#20757) (Bazyli Brzóska) - 9c218ef linter/eslint-vitest-plugin: Remove pending fix status for require-local-test-context-for-concurrent-snapshot (#20890) (Said Atrahouch) ### ⚡ Performance - fb52383 napi/parser, linter/plugins: Clear buffers and source texts earlier (#21025) (overlookmotel) - 3b7dec4 napi/parser, linter/plugins: Use `utf8Slice` for decoding UTF-8 strings (#21022) (overlookmotel) - 012c924 napi/parser, linter/plugins: Speed up decoding strings in raw transfer (#21021) (overlookmotel) - 55e1e9b napi/parser, linter/plugins: Initialize vars as 0 (#21020) (overlookmotel) - c25ef02 napi/parser, linter/plugins: Simplify branch condition in `deserializeStr` (#21019) (overlookmotel) - 9f494c3 napi/parser, linter/plugins: Raw transfer use `String.fromCharCode` in string decoding (#21018) (overlookmotel) - 0503a78 napi/parser, linter/plugins: Faster deserialization of `raw` fields (#20923) (overlookmotel) - a24f75e napi/parser: Optimize string deserialization for non-ASCII sources (#20834) (Joshua Tuddenham) ### 📚 Documentation - af72b80 oxlint: Fix typo for --tsconfig (#20889) (leaysgur) - 70c53b1 linter: Highlight that tsconfig is not respected in type aware linting (#20884) (camc314) # Oxfmt ### 🚀 Features - 35cf6e8 oxfmt: Add node version hint for ts config import failures (#21046) (camc314) ### 🐛 Bug Fixes - dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya kawaguchi) - 9d45511 oxfmt: Propagate file write errors instead of panicking (#20997) (leaysgur) - 139ddd9 formatter: Handle leading comment after array elision (#20987) (leaysgur) - 4216380 oxfmt: Support `.editorconfig` `tab_width` fallback (#20988) (leaysgur) - d10df39 formatter: Resolve pending space in fits measurer before expanded-mode early exit (#20954) (Dunqing) - f9ef1bd formatter: Avoid breaking after `=>` when arrow body has JSDoc type cast (#20857) (bab) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jan 6, 2026

camc314 self-assigned this Jan 6, 2026

yue4u mentioned this pull request Jan 19, 2026

chore(linter): Add message to diagnostics optimizations debug assert #18218

Merged

yue4u force-pushed the object-shorthand branch from 4626a23 to 86dbf27 Compare January 19, 2026 08:30

yue4u force-pushed the object-shorthand branch 2 times, most recently from 9ece3d2 to 735337b Compare January 24, 2026 09:37

yue4u commented Jan 24, 2026

View reviewed changes

yue4u force-pushed the object-shorthand branch from 4dcef89 to 731aa97 Compare January 24, 2026 09:52

yue4u changed the title ~~feat(linter/eslint): eslint/object-shorthand (WIP)~~ feat(linter/eslint): eslint/object-shorthand Jan 24, 2026

yue4u marked this pull request as ready for review January 24, 2026 15:28

yue4u requested a review from camc314 as a code owner January 24, 2026 15:28

yue4u commented Jan 24, 2026

View reviewed changes

crates/oxc_linter/src/rules/eslint/object_shorthand.rs Outdated Show resolved Hide resolved

yue4u force-pushed the object-shorthand branch from f3f1e53 to 3b6432f Compare February 8, 2026 23:30

KubaJastrz and others added 13 commits March 30, 2026 18:00

object-shorthand test cases

04628e7

parse config

95b8370

remove regex for now

f8ea3a8

lint

6f2ce31

use new diagnostics

61d6e54

add new test cases from eslint

c86cf35

report longform methods and properties

7e6d695

refactor(diagnostics): s/warning/warn

48b4474

simplify code

dabf3d1

fixer for longform properties

6cf545b

fixer for shorthand properties

5e9b23e

fix: cleanup objectshorthand rule def

0fc1537

feat: impl shorthand fixer

5d33e4d

yue4u and others added 13 commits March 30, 2026 18:00

fix: create stack if lexical_scope_stack is empty

ac40e08

fix: skip if contains jsdoc

b10030d

fix: port jsdoc tests

80d6f57

fix: rerun cargo run -p oxc_linter_codegen

2ce1766

fix: cleanup debug leftover

dec87fb

fix: lint

c90e22a

fix: cleanup clone count

baae761

fix: impl default for ObjectShorthandConfig

7e24f53

reorder imports

89c28ef

remove unneede scope/rule from diagnostic msgs

51cf1a6

remove superfluous doc comment

f2586e8

update snap

e3b7f74

refactor: avoid full ast traversal

8c2dd62

camc314 force-pushed the object-shorthand branch from 3b6432f to 8c2dd62 Compare March 30, 2026 17:16

camc314 added 3 commits March 30, 2026 18:18

remove unneeded snaps

7579ff8

re-gen tests

00fcc45

update snap, disable failing test

9f6c182

camc314 requested a review from Copilot March 30, 2026 17:23

Copilot started reviewing on behalf of camc314 March 30, 2026 17:23 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

camc314 added 5 commits March 30, 2026 18:31

remove unused import

256831a

rename var

0c8d814

add FIXME comment

37990ca

jsx parser with generics

32ae5a1

refactor object-shorthand config handling

49eb9f9

camc314 changed the title ~~feat(linter/eslint): eslint/object-shorthand~~ feat(linter): implement eslint/object-shorthand Mar 30, 2026

camc314 approved these changes Mar 30, 2026

View reviewed changes

camc314 merged commit 0f01fbd into oxc-project:main Mar 30, 2026
26 checks passed

Boshen mentioned this pull request Apr 6, 2026

release(apps): oxlint v1.59.0 && oxfmt v0.44.0 #21085

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): implement eslint/object-shorthand#17688

feat(linter): implement eslint/object-shorthand#17688
camc314 merged 44 commits intooxc-project:mainfrom
yue4u:object-shorthand

yue4u commented Jan 6, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jan 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yue4u commented Jan 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

yue4u commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yue4u commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yue4u commented Jan 6, 2026 •

edited

Loading

codspeed-hq bot commented Jan 24, 2026 •

edited

Loading

yue4u commented Jan 24, 2026 •

edited

Loading