perf(linter/plugins): pre-populate cache of VisitProp objects#20189
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
This was referenced Mar 10, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 10, 2026
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to optimize JS visitor compilation in apps/oxlint by pre-populating the VisitProp object cache up-front (mirroring the earlier EnterExit cache optimization) to avoid repeated branching in the main loop.
Changes:
- Pre-populate
visitPropsCachebefore iterating visitor keys. - Replace per-iteration “get-or-create” branching with unconditional reuse from the cache.
overlookmotel
force-pushed
the
om/03-10-perf_linter_plugins_pre-populate_cache_of_enterexit_objects
branch
from
a49e3e4 to
f32b86c
Compare
overlookmotel
force-pushed
the
om/03-09-perf_linter_plugins_pre-populate_cache_of_visitprop_objects
branch
from
095db8f to
b2e9703
Compare
Contributor
Merge activity
|
Perf optimization to visitor compilation. Apply the same optimization as #20187 to the cache of `VisitProp` objects. Instead of main loop in `addVisitorToCompiled` checking on each turn of the loop whether cache contains a `VisitProp` object it can reuse, instead pre-populate the cache to ensure it always does.
graphite-app
bot
force-pushed
the
om/03-10-perf_linter_plugins_pre-populate_cache_of_enterexit_objects
branch
from
f32b86c to
3061acb
Compare
graphite-app
bot
force-pushed
the
om/03-09-perf_linter_plugins_pre-populate_cache_of_visitprop_objects
branch
from
b2e9703 to
8742f8b
Compare
Base automatically changed from
om/03-10-perf_linter_plugins_pre-populate_cache_of_enterexit_objects
to
main
March 10, 2026 12:01
graphite-app
bot
deleted the
om/03-09-perf_linter_plugins_pre-populate_cache_of_visitprop_objects
branch
leaysgur
added a commit
that referenced
this pull request
Mar 11, 2026
# Oxlint ### 🚀 Features - 04a5ce0 oxlint: Support `vite.config.ts` `.lint` field (#20214) (leaysgur) - 1735215 linter: Implement `react/no-clone-element` rule. (#20129) (connorshea) - 68e6f6f linter: Implement `react/no-react-children` rule. (#20104) (connorshea) - fe3b32e linter/plugins: Add `oxlint-plugin-eslint` package (#20009) (overlookmotel) ### 🐛 Bug Fixes - 05f6a09 linter/no-inline-comments: Deserialize rule options with serde (#20207) (camc314) - c7eb09d linter/default-case: Deserialize rule options with serde (#20206) (camc314) - f85e16c linter/plugins: Fix types for visitor compilation (#20203) (overlookmotel) - 44e24e0 linter/exhaustive-deps: Ignore type-only typeof deps (#20201) (camc314) - 0b04998 linter/no-fallthrough: Deserialize rule options with serde (#20192) (camc314) - a1031cb linter/new-cap: Deserialize rule options with serde (#20161) (camc314) - ad27fd6 linter: Add help messages to import plugin diagnostics (#20158) (John Costa) - 1340307 linter/plugins: Ensure `after` hooks always run (#20167) (overlookmotel) - c4812ec linter/plugins: Reset visitor compilation state if error during compilation (#20166) (overlookmotel) - 887eecc linter/plugins: Add license notice to `oxlint-plugin-eslint` package (#20164) (overlookmotel) - e1713a4 linter/plugins: Include common chunks in `oxlint-plugin-eslint` package (#20163) (overlookmotel) - a9acb2b linter: Check `globals` entry for `no-undef`, only check es2026 globals for `no-extend-native` and `no-constant-binary-expression` (#20089) (Sysix) - 5559f0d linter/no-unused-vars: `reportUsedIgnorePattern` should not report used rest siblings (#20108) (Don Isaac) - de7c0e2 linter/plugins: Correct error message for `markVariableAsUsed` (#20152) (overlookmotel) ### ⚡ Performance - 3a86427 linter/plugins: Pre-populate cache of `EnterExit` objects at startup (#20194) (overlookmotel) - d243391 linter/plugins: Replace arrays with `Uint8Array`s (#20190) (overlookmotel) - 8742f8b linter/plugins: Pre-populate cache of `VisitProp` objects (#20189) (overlookmotel) - 3061acb linter/plugins: Pre-populate cache of `EnterExit` objects (#20187) (overlookmotel) - c73912b linter/plugins: Free visit functions earlier (#20186) (overlookmotel) - d9f8ff4 linter/plugins: Faster reset of visitor state (#20185) (overlookmotel) - 42aff15 oxlint/lsp: Avoid computing diagnostics for non invoked code actions requests (#20080) (Sysix) ### 📚 Documentation - a080650 linter/plugins: Fix documentation of visitor compilation (#20202) (overlookmotel) - 542a04a linter: Add a link to the cyclomatic complexity Wikipedia article in `eslint/complexity` (#20174) (connorshea) # Oxfmt ### 🚀 Features - 95943aa oxfmt: Support `vite.config.*` `.fmt` field (#20197) (leaysgur) - 172fc07 oxfmt: .js/.ts config file support (#20135) (leaysgur) ### 🐛 Bug Fixes - e483569 oxfmt: Avoid double-escaping in css-in-js (#20211) (leaysgur) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perf optimization to visitor compilation.
Apply the same optimization as #20187 to the cache of
VisitPropobjects.Instead of main loop in
addVisitorToCompiledchecking on each turn of the loop whether cache contains aVisitPropobject it can reuse, instead pre-populate the cache to ensure it always does.