fix(linter/no-unused-vars): reportUsedIgnorePattern should not report used rest siblings

[DonIsaac]

What This PR Does

Fixes a bug where setting { "ignoreRestSiblings": true, "reportUsedIgnorePattern": true } would report used unpacked properties as a lint rule violation.

/* no-unused-vars: ["error", { "ignoreRestSiblings": true, "reportUsedIgnorePattern": true }] */
export const MyComponent = ({ role = "nav" , ...props }) => (
  <div
    role={role} // <-- Would report "Variable 'role' is marked as ignored but is not used"
    {...props}
  />
)

Changes

• refactor is_ignored to return Option<IgnoreReason> instead of bool. None is not ignored, Some is ignored for some cause.
• Only ignored symbols with a "NamePattern" reason (ignored because of a match with varsIgnorePattern, argsIgnorePattern, ...fooIgnorePattern) get reported when reportUsedIgnorePattern is set

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

---

_{Comparing DonIsaac:don/fix/nuv-report-unused-rest-siblings (834f413) with main (a3013ae)}

Footnotes

1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes a bug where { "ignoreRestSiblings": true, "reportUsedIgnorePattern": true } incorrectly reports used properties that were only ignored because they are rest-siblings (e.g., role in ({ role = "nav", ...props }) => ...). The fix refactors is_ignored to return an Option<IgnoreReason> (via the new Ignored struct) instead of bool, allowing the diagnostic logic to distinguish why a symbol was ignored and only trigger reportUsedIgnorePattern for NamePattern-based ignores.

Changes:

• Introduces a new IgnoreReason enum and Ignored newtype wrapper in ignored.rs, with FoundStatus updated to carry a reason.
• Updates is_ignored and related helper functions to return Ignored with a specific IgnoreReason.
• Adds a comprehensive test_ignore test function in oxc.rs and re-enables a previously commented-out ESLint conformance test.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ignored.rs	Core refactoring: new IgnoreReason enum, Ignored struct, updated FoundStatus and all is_ignored_* helpers
mod.rs	Updated run_on_symbol_internal to use Ignored and match on IgnoreReason
usage.rs	Adapted call sites to call .is_some() on Ignored where a bool was previously expected
binding_pattern.rs	Adapted is_ignored_array_destructured call to use .is_some()
tests/oxc.rs	New test_ignore test covering the fixed behavior and edge cases
tests/eslint.rs	Re-enables a previously commented-out foox in IIFE test
snapshots/eslint_no_unused_vars@oxc-ignore.snap	New snapshot for test_ignore
snapshots/eslint_no_unused_vars@eslint.snap	Updated snapshot for the re-enabled ESLint test

[camc314]

Thank you Don!