Skip to content

fix(linter/plugins): add license notice to oxlint-plugin-eslint package#20164

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-10-fix_linter_plugins_add_license_notice_to_oxlint-plugin-eslint_package
Mar 10, 2026
Merged

fix(linter/plugins): add license notice to oxlint-plugin-eslint package#20164
graphite-app[bot] merged 1 commit intomainfrom
om/03-10-fix_linter_plugins_add_license_notice_to_oxlint-plugin-eslint_package

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 10, 2026

oxlint-plugin-eslint package bundles all of ESLint's rules. Add a license header crediting ESLint for the code, and linking to the MIT license.

Copy link
Member Author

overlookmotel commented Mar 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Mar 10, 2026
@overlookmotel overlookmotel marked this pull request as ready for review March 10, 2026 00:20
@overlookmotel overlookmotel requested a review from camc314 as a code owner March 10, 2026 00:20
Copilot AI review requested due to automatic review settings March 10, 2026 00:20
@overlookmotel overlookmotel self-assigned this Mar 10, 2026
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Mar 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an attribution/license notice to the bundled output for the oxlint-plugin-eslint package, which contains vendored ESLint rule implementations.

Changes:

  • Adds a JS banner comment crediting ESLint as the source of the copied rule code.
  • Links the banner to ESLint’s MIT license (permalink).
Comments suppressed due to low confidence (1)

apps/oxlint/tsdown.config.ts:153

  • The license banner is only applied to the ESM index build. The package also emits many CommonJS rule entrypoints (pluginEslintRulesEntries), and those output files currently won’t carry the notice. If the intent is to ensure the distributed oxlint-plugin-eslint artifacts are clearly attributed/licensed, apply the same banner to the CommonJS build as well (or move the banner into pluginEslintPkgConfig so it covers both configs).
    banner: {
      js: [
        "/**",
        " * ESLint's rules code copied from https://github.com/eslint/eslint",
        " *",
        " * License: MIT",
        " * https://github.com/eslint/eslint/blob/a0d1a3772679d3d74bb860fc65b5b58678acd452/LICENSE",
        " */",
      ].join("\n"),
    },
  },
  {
    ...pluginEslintPkgConfig,
    entry: pluginEslintRulesEntries,
    format: "commonjs",

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 10, 2026
Copy link
Member Author

overlookmotel commented Mar 10, 2026

Merge activity

…kage (#20164)

`oxlint-plugin-eslint` package bundles all of ESLint's rules. Add a license header crediting ESLint for the code, and linking to the MIT license.
@graphite-app graphite-app bot force-pushed the om/03-09-fix_linter_plugins_include_common_chunks_in_oxlint-plugin-eslint_package branch from abc0806 to e1713a4 Compare March 10, 2026 00:44
@graphite-app graphite-app bot force-pushed the om/03-10-fix_linter_plugins_add_license_notice_to_oxlint-plugin-eslint_package branch from 52ab59a to 887eecc Compare March 10, 2026 00:44
Base automatically changed from om/03-09-fix_linter_plugins_include_common_chunks_in_oxlint-plugin-eslint_package to main March 10, 2026 00:55
@graphite-app graphite-app bot merged commit 887eecc into main Mar 10, 2026
20 checks passed
@graphite-app graphite-app bot deleted the om/03-10-fix_linter_plugins_add_license_notice_to_oxlint-plugin-eslint_package branch March 10, 2026 00:55
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 10, 2026
leaysgur added a commit that referenced this pull request Mar 11, 2026
# Oxlint
### 🚀 Features

- 04a5ce0 oxlint: Support `vite.config.ts` `.lint` field (#20214)
(leaysgur)
- 1735215 linter: Implement `react/no-clone-element` rule. (#20129)
(connorshea)
- 68e6f6f linter: Implement `react/no-react-children` rule. (#20104)
(connorshea)
- fe3b32e linter/plugins: Add `oxlint-plugin-eslint` package (#20009)
(overlookmotel)

### 🐛 Bug Fixes

- 05f6a09 linter/no-inline-comments: Deserialize rule options with serde
(#20207) (camc314)
- c7eb09d linter/default-case: Deserialize rule options with serde
(#20206) (camc314)
- f85e16c linter/plugins: Fix types for visitor compilation (#20203)
(overlookmotel)
- 44e24e0 linter/exhaustive-deps: Ignore type-only typeof deps (#20201)
(camc314)
- 0b04998 linter/no-fallthrough: Deserialize rule options with serde
(#20192) (camc314)
- a1031cb linter/new-cap: Deserialize rule options with serde (#20161)
(camc314)
- ad27fd6 linter: Add help messages to import plugin diagnostics
(#20158) (John Costa)
- 1340307 linter/plugins: Ensure `after` hooks always run (#20167)
(overlookmotel)
- c4812ec linter/plugins: Reset visitor compilation state if error
during compilation (#20166) (overlookmotel)
- 887eecc linter/plugins: Add license notice to `oxlint-plugin-eslint`
package (#20164) (overlookmotel)
- e1713a4 linter/plugins: Include common chunks in
`oxlint-plugin-eslint` package (#20163) (overlookmotel)
- a9acb2b linter: Check `globals` entry for `no-undef`, only check
es2026 globals for `no-extend-native` and
`no-constant-binary-expression` (#20089) (Sysix)
- 5559f0d linter/no-unused-vars: `reportUsedIgnorePattern` should not
report used rest siblings (#20108) (Don Isaac)
- de7c0e2 linter/plugins: Correct error message for `markVariableAsUsed`
(#20152) (overlookmotel)

### ⚡ Performance

- 3a86427 linter/plugins: Pre-populate cache of `EnterExit` objects at
startup (#20194) (overlookmotel)
- d243391 linter/plugins: Replace arrays with `Uint8Array`s (#20190)
(overlookmotel)
- 8742f8b linter/plugins: Pre-populate cache of `VisitProp` objects
(#20189) (overlookmotel)
- 3061acb linter/plugins: Pre-populate cache of `EnterExit` objects
(#20187) (overlookmotel)
- c73912b linter/plugins: Free visit functions earlier (#20186)
(overlookmotel)
- d9f8ff4 linter/plugins: Faster reset of visitor state (#20185)
(overlookmotel)
- 42aff15 oxlint/lsp: Avoid computing diagnostics for non invoked code
actions requests (#20080) (Sysix)

### 📚 Documentation

- a080650 linter/plugins: Fix documentation of visitor compilation
(#20202) (overlookmotel)
- 542a04a linter: Add a link to the cyclomatic complexity Wikipedia
article in `eslint/complexity` (#20174) (connorshea)
# Oxfmt
### 🚀 Features

- 95943aa oxfmt: Support `vite.config.*` `.fmt` field (#20197)
(leaysgur)
- 172fc07 oxfmt: .js/.ts config file support (#20135) (leaysgur)

### 🐛 Bug Fixes

- e483569 oxfmt: Avoid double-escaping in css-in-js (#20211) (leaysgur)

Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants