Skip to content

refactor(linter/jsx-key): use IdentifierReference::reference_id over cell access#19494

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess
Feb 17, 2026
Merged

refactor(linter/jsx-key): use IdentifierReference::reference_id over cell access#19494
graphite-app[bot] merged 1 commit intomainfrom
c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 17, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Feb 17, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 17, 2026
@camc314 camc314 marked this pull request as ready for review February 17, 2026 13:25
Copilot AI review requested due to automatic review settings February 17, 2026 13:25
@camc314 camc314 self-assigned this Feb 17, 2026
@camc314 camc314 changed the title refactor(linter/jsx-key): use IdentifierReference::reference_id over cell acess refactor(linter/jsx-key): use IdentifierReference::reference_id over cell access Feb 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the React jsx-key linter rule helper to use the post-semantic IdentifierReference::reference_id() accessor instead of directly reading the underlying Cell<Option<ReferenceId>>, aligning with the “post-semantic AST” assumption used throughout the linter.

Changes:

  • Replaced manual ident.reference_id.get() option handling with ident.reference_id() accessor.
  • Simplified the reference lookup flow by removing an outer Option guard.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 17, 2026

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess (40f047f) with main (36bf284)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (40f047f) during the generation of this report, so 36bf284 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
@camc314 camc314 force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 01ed3da to 33e1db7 Compare February 17, 2026 13:48
@camc314 camc314 force-pushed the c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess branch 2 times, most recently from d037ad4 to 784509b Compare February 17, 2026 16:35
@camc314 camc314 force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 33e1db7 to 71067ff Compare February 17, 2026 16:35
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch 2 times, most recently from 7bad5a4 to 9bc4658 Compare February 17, 2026 16:59
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess branch from 784509b to 2e7fa91 Compare February 17, 2026 16:59
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess branch from 9bc4658 to 36bf284 Compare February 17, 2026 17:06
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Feb 17, 2026
Base automatically changed from c/02-17-refactor_linter_preserve-caught-error_use_identifierreference_reference_id_over_cell_acess to main February 17, 2026 17:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess branch from 2e7fa91 to 40f047f Compare February 17, 2026 17:19
@graphite-app graphite-app bot merged commit 40f047f into main Feb 17, 2026
29 checks passed
@graphite-app graphite-app bot deleted the c/02-17-refactor_linter_jsx-key_use_identifierreference_reference_id_over_cell_acess branch February 17, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants