Skip to content

refactor(linter/jsx-key): use IdentifierReference::reference_id over cell access #19494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 17, 2026
Merged

refactor(linter/jsx-key): use IdentifierReference::reference_id over cell access #19494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions crates/oxc_linter/src/rules/react/jsx_key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,20 +188,18 @@ fn is_children_from_react<'a>(ident: &IdentifierReference<'a>, ctx: &LintContext
// e.g., const { Children } = React; or const { Children } = Act;
if name == CHILDREN {
// Get the symbol ID from the reference
if let Some(reference_id) = ident.reference_id.get() {
let reference = ctx.scoping().get_reference(reference_id);
if let Some(symbol_id) = reference.symbol_id() {
// Get the declaration node
let decl_id = ctx.scoping().symbol_declaration(symbol_id);
let decl_node = ctx.nodes().get_node(decl_id);

// Check if this is a VariableDeclarator with ObjectPattern
if let AstKind::VariableDeclarator(var_decl) = decl_node.kind() {
// Check if init is an identifier imported from React
if let Some(Expression::Identifier(init_ident)) = var_decl.init.as_ref() {
// Check if the init identifier is imported from 'react' module
return import_matcher(ctx, init_ident.name.as_str(), REACT_MODULE);
}
let reference = ctx.scoping().get_reference(ident.reference_id());
if let Some(symbol_id) = reference.symbol_id() {
// Get the declaration node
let decl_id = ctx.scoping().symbol_declaration(symbol_id);
let decl_node = ctx.nodes().get_node(decl_id);

// Check if this is a VariableDeclarator with ObjectPattern
if let AstKind::VariableDeclarator(var_decl) = decl_node.kind() {
// Check if init is an identifier imported from React
if let Some(Expression::Identifier(init_ident)) = var_decl.init.as_ref() {
// Check if the init identifier is imported from 'react' module
return import_matcher(ctx, init_ident.name.as_str(), REACT_MODULE);
}
}
}
Expand Down
Loading