Skip to content

refactor(linter/prefer-const): use IdentifierReference::reference_id over cell access#19492

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess
Feb 17, 2026
Merged

refactor(linter/prefer-const): use IdentifierReference::reference_id over cell access#19492
graphite-app[bot] merged 1 commit intomainfrom
c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 17, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Feb 17, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-linter Area - Linter label Feb 17, 2026
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 17, 2026
@camc314 camc314 changed the title refactor(linter/prefer-const): use IdentifierReference::reference_id over cell acess refactor(linter/prefer-const): use IdentifierReference::reference_id over cell access Feb 17, 2026
@camc314 camc314 marked this pull request as ready for review February 17, 2026 13:24
Copilot AI review requested due to automatic review settings February 17, 2026 13:24
@camc314 camc314 self-assigned this Feb 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the prefer-const ESLint rule implementation to use the generated IdentifierReference::reference_id() accessor (post-semantic API) instead of directly reading the underlying Cell<Option<ReferenceId>>, aligning this rule with the newer AST access patterns used across the linter.

Changes:

  • Replace ident.reference_id.get() access with ident.reference_id() in array destructuring assignment-target handling.
  • Replace ident.binding.reference_id.get() access with ident.binding.reference_id() in object destructuring assignment-target handling.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 17, 2026

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess (4be0ba0) with c/02-17-refactor_linter_consistent-indexed-object-style_use_identifierreference_reference_id_over_cell_acess (43b3c40)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
@graphite-app graphite-app bot changed the base branch from c/02-17-refactor_linter_consistent-indexed-object-style_use_identifierreference_reference_id_over_cell_acess to graphite-base/19492 February 17, 2026 13:48
@camc314 camc314 force-pushed the graphite-base/19492 branch from 43b3c40 to 556bdfc Compare February 17, 2026 13:48
@camc314 camc314 force-pushed the c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess branch from 4be0ba0 to 8f659ba Compare February 17, 2026 13:48
@camc314 camc314 changed the base branch from graphite-base/19492 to c/02-17-refactor_linter_consistent-indexed-object-style_use_identifierreference_reference_id_over_cell_acess February 17, 2026 13:48
@graphite-app graphite-app bot changed the base branch from c/02-17-refactor_linter_consistent-indexed-object-style_use_identifierreference_reference_id_over_cell_acess to graphite-base/19492 February 17, 2026 13:53
@camc314 camc314 force-pushed the c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess branch from 8f659ba to fbb7f21 Compare February 17, 2026 14:00
@camc314 camc314 force-pushed the graphite-base/19492 branch from 556bdfc to c7e31b2 Compare February 17, 2026 14:00
@graphite-app graphite-app bot changed the base branch from graphite-base/19492 to main February 17, 2026 14:00
@camc314 camc314 force-pushed the c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess branch from fbb7f21 to 296a62c Compare February 17, 2026 16:35
@graphite-app graphite-app bot force-pushed the c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess branch from 296a62c to fbcbb45 Compare February 17, 2026 16:52
@graphite-app graphite-app bot merged commit fbcbb45 into main Feb 17, 2026
21 checks passed
@graphite-app graphite-app bot deleted the c/02-17-refactor_linter_prefer-const_use_identifierreference_reference_id_over_cell_acess branch February 17, 2026 16:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants