refactor(linter/no-useless-error-capture-stack-trace): use IdentifierReference::reference_id over cell access

[camc314]

No description provided.

[camc314]

• refactor(linter/no-useless-error-capture-stack-trace): use IdentifierReference::reference_id over cell access #19495 👈 (View in Graphite)
• refactor(linter/jsx-key): use IdentifierReference::reference_id over cell access #19494
• refactor(linter/preserve-caught-error): use IdentifierReference::reference_id over cell access #19493
• refactor(linter/prefer-const): use IdentifierReference::reference_id over cell access #19492
• refactor(linter/consistent-indexed-object-style): use IdentifierReference::reference_id over cell access #19491
• perf(linter/consistent-index-object-style): resolve circular type refs semantically #19490
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Refactors the unicorn/no-useless-error-capture-stack-trace linter rule to use the post-semantic AST accessor IdentifierReference::reference_id() (instead of accessing the internal cell) when resolving identifier references via scoping.

Changes:

• Replace ident.reference_id.get() Option-unwrapping with ident.reference_id() accessor when looking up the symbol for an identifier reference.
• Remove trailing whitespace in multi-line fixer expected-output test strings.

[codspeed-hq]

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing c/02-17-refactor_linter_no-useless-error-capture-stack-trace_use_identifierreference_reference_id_over_cell_acess (0a8764b) with main (36bf284)²}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (0a8764b) during the generation of this report, so 36bf284 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[graphite-app]

Merge activity

• Feb 17, 5:06 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Feb 17, 5:07 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #19493.
• Feb 17, 5:07 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #19493.
• Feb 17, 5:18 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 17, 5:18 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Feb 17, 5:26 PM UTC: Merged by the Graphite merge queue.