perf(formatter): don't call sort_tailwind_classes if no classes need to be sorted#17698
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 6, 2026
Conversation
github-actions
bot
added
A-formatter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #17698 will not alter performanceComparing Summary
Footnotes
|
Dunqing
force-pushed
the
01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields
branch
from
edce2c8 to
207d327
Compare
Dunqing
force-pushed
the
01-06-perf_formatter_don_t_call_sort_tailwind_classes_if_no_classes_need_to_be_sorted
branch
from
85d7bd7 to
5919086
Compare
leaysgur
approved these changes
Jan 6, 2026
Member
Merge activity
|
Member
😆 |
…d to be sorted (#17698) If the classes are empty, that means no classes need to be sorted. Then return the original one to avoid calling the JS side, which is quite a costly function. After this, the formatting time went from `8s` to `2s` in the `outline` repo locally.
graphite-app
bot
force-pushed
the
01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields
branch
from
207d327 to
1aa7591
Compare
graphite-app
bot
force-pushed
the
01-06-perf_formatter_don_t_call_sort_tailwind_classes_if_no_classes_need_to_be_sorted
branch
from
5919086 to
c6a99fd
Compare
Base automatically changed from
01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields
to
main
January 6, 2026 08:41
graphite-app
bot
deleted the
01-06-perf_formatter_don_t_call_sort_tailwind_classes_if_no_classes_need_to_be_sorted
branch
Dunqing
added a commit
that referenced
this pull request
Jan 6, 2026
# Oxlint # Oxfmt ### 🚀 Features - a19cc93 oxfmt: Add debug logging to oxfmt LSP to troubleshoot resolved options at runtime (#17695) (Nicholas Rayburn) ### 🐛 Bug Fixes - 3b4aced formatter: Should not treat multi-type arguments of TSTypeReference as a complex type (#17708) (Dunqing) - dcfdd41 formatter: Should not set up tailwindcss callback when no tailwindcss configuration is set (#17696) (Dunqing) - 6f65901 formatter: Return original classes when there are no tailwindcss classes sort callback (#17689) (Dunqing) ### ⚡ Performance - c6a99fd formatter: Don't call `sort_tailwind_classes` if no classes need to be sorted (#17698) (Dunqing) Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the classes are empty, that means no classes need to be sorted. Then return the original one to avoid calling the JS side, which is quite a costly function.
After this, the formatting time went from
8sto2sin theoutlinerepo locally.