fix(formatter): should not set up tailwindcss callback when no tailwindcss configuration is set

[Dunqing]

Only set up the tailwindcss callback when the experimentalTailwindcss configuration is set. Previously, it would also set up when the emebeddedLanguageFormatting is on.

[Dunqing]

• perf(formatter): don't call sort_tailwind_classes if no classes need to be sorted #17698
• refactor(formatter): remove unnecessary clone for FormatContext and all its fields #17697
• fix(formatter): should not set up tailwindcss callback when no tailwindcss configuration is set #17696 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17696 will not alter performance

_{Comparing 01-06-fix_formatter_should_not_set_up_tailwindcss_callback_when_no_tailwindcss_configuration_is_set (56073c5) with main (6f65901)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on main (555ed33) during the generation of this report, so 6f65901 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes the formatter to only set up the Tailwind CSS callback when the experimentalTailwindcss configuration is explicitly provided, preventing unnecessary callback initialization when only embeddedLanguageFormatting is enabled.

Key changes:

• Modified ExternalCallbacks API to accept Option<Callback> instead of bare Callback types
• Moved callback creation logic to conditionally instantiate callbacks based on configuration
• Simplified the caller code to delegate configuration checks to the callback builder

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_formatter/src/external_formatter.rs	Changed with_embedded_formatter and with_tailwind methods to accept Option<Callback> parameters
apps/oxfmt/src/core/external_formatter.rs	Added conditional logic to only create embedded and Tailwind callbacks when their respective configurations are enabled
apps/oxfmt/src/core/format.rs	Simplified caller code to use the updated to_external_callbacks signature and removed redundant configuration checks

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Jan 6, 8:33 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Jan 6, 8:40 AM UTC: Merged by the Graphite merge queue.