fix(formatter): should not treat multi-type arguments of TSTypeReference as a complex type

[Dunqing]

Input:

// Non-complex type arguments, as none of the type arguments of Record is a complex type.
const result = configurationService.getValue<Record<string, boolean>>(
  enalementSetting
);

Before output:

// Non-complex type arguments, as none of the type arguments of Record is a complex type.
const result = configurationService.getValue<
  Record<string, boolean>
>(enalementSetting);

Prettier Playground
After output:

// Non-complex type arguments, as none of the type arguments of Record is a complex type.
const result =
  configurationService.getValue<Record<string, boolean>>(enalementSetting);

[Dunqing]

• fix(formatter): should not treat multi-type arguments of TSTypeReference as a complex type #17708 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17708 will not alter performance

_{Comparing 01-06-fix_formatter_should_not_treat_multi-type_arguments_of_tstypereference_as_a_complex_type (90c6356) with main (c6a99fd)}

Summary

✅ 38 untouched
⏩ 7 skipped¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes a formatter bug where type arguments in TSTypeReference were incorrectly considered complex when they contained multiple type parameters, even if none of those parameters were actually complex types. The fix ensures that Record<string, boolean> is not treated as a complex type, preventing unnecessary line breaks in formatted code.

Key changes:

• Modified the logic in is_complex_type_arguments to check individual type parameters instead of recursively calling itself
• Added a test case demonstrating the fix with Record<string, boolean>

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_formatter/src/utils/assignment_like.rs	Changed the logic from recursively checking if nested type arguments are complex (which would return true for >1 params) to checking if any individual nested type parameter is a complex type
crates/oxc_formatter/tests/fixtures/ts/assignments/complex-type-arguments.ts	Added test case with Record<string, boolean> to verify non-complex multi-parameter types are handled correctly
crates/oxc_formatter/tests/fixtures/ts/assignments/complex-type-arguments.ts.snap	Updated snapshot with expected output for the new test case at different print widths

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[leaysgur]

Merge activity

• Jan 6, 9:36 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 6, 9:36 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Jan 6, 9:43 AM UTC: Merged by the Graphite merge queue.