Skip to content

refactor(formatter): remove unnecessary clone for FormatContext and all its fields#17697

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields
Jan 6, 2026
Merged

refactor(formatter): remove unnecessary clone for FormatContext and all its fields#17697
graphite-app[bot] merged 1 commit intomainfrom
01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 6, 2026

Clone trait is unnecessary, so remove it.

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 6, 2026
Copy link
Member Author

Dunqing commented Jan 6, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

CodSpeed Performance Report

Merging #17697 will not alter performance

Comparing 01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields (207d327) with 01-06-fix_formatter_should_not_set_up_tailwindcss_callback_when_no_tailwindcss_configuration_is_set (56073c5)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing marked this pull request as ready for review January 6, 2026 07:55
@Dunqing Dunqing force-pushed the 01-06-fix_formatter_should_not_set_up_tailwindcss_callback_when_no_tailwindcss_configuration_is_set branch from 5044a86 to 56073c5 Compare January 6, 2026 08:09
@Dunqing Dunqing force-pushed the 01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields branch from edce2c8 to 207d327 Compare January 6, 2026 08:09
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 6, 2026

Merge activity

…ll its fields (#17697)

Clone trait is unnecessary, so remove it.
@graphite-app graphite-app bot force-pushed the 01-06-fix_formatter_should_not_set_up_tailwindcss_callback_when_no_tailwindcss_configuration_is_set branch from 56073c5 to dcfdd41 Compare January 6, 2026 08:34
@graphite-app graphite-app bot force-pushed the 01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields branch from 207d327 to 1aa7591 Compare January 6, 2026 08:34
Base automatically changed from 01-06-fix_formatter_should_not_set_up_tailwindcss_callback_when_no_tailwindcss_configuration_is_set to main January 6, 2026 08:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 6, 2026
@graphite-app graphite-app bot merged commit 1aa7591 into main Jan 6, 2026
21 checks passed
@graphite-app graphite-app bot deleted the 01-06-refactor_formatter_remove_unnecessary_clone_for_formatcontext_and_all_its_fields branch January 6, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants