Skip to content

fix(formatter): shouldn't treat TaggedTemplateExpression as a simple argument in the member chain#17256

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-22-fix_formatter_shouldn_t_treat_taggedtemplateexpression_as_a_simple_argument_in_the_member_chain
Dec 22, 2025
Merged

fix(formatter): shouldn't treat TaggedTemplateExpression as a simple argument in the member chain#17256
graphite-app[bot] merged 1 commit intomainfrom
12-22-fix_formatter_shouldn_t_treat_taggedtemplateexpression_as_a_simple_argument_in_the_member_chain

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 22, 2025

Copy link
Member Author

Dunqing commented Dec 22, 2025

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #17256 will not alter performance

Comparing 12-22-fix_formatter_shouldn_t_treat_taggedtemplateexpression_as_a_simple_argument_in_the_member_chain (97f9b16) with 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call (173fb14)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing changed the title fix(formatter): shouldn't treat TaggedTemplateExpression as a simple argument in the member chain fix(formatter): shouldn't treat TaggedTemplateExpression as a simple argument in the member chain Dec 22, 2025
@Dunqing Dunqing marked this pull request as ready for review December 22, 2025 08:52
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 22, 2025
@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch 2 times, most recently from 0311b3b to 63e2659 Compare December 22, 2025 09:21
@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_shouldn_t_treat_taggedtemplateexpression_as_a_simple_argument_in_the_member_chain branch from 97f9b16 to e3290dc Compare December 22, 2025 09:21
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 22, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch from 63e2659 to 6ad3951 Compare December 22, 2025 09:46
@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_shouldn_t_treat_taggedtemplateexpression_as_a_simple_argument_in_the_member_chain branch from e3290dc to fa5cef3 Compare December 22, 2025 09:46
Base automatically changed from 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call to main December 22, 2025 09:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 22, 2025
@graphite-app graphite-app bot merged commit fa5cef3 into main Dec 22, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-22-fix_formatter_shouldn_t_treat_taggedtemplateexpression_as_a_simple_argument_in_the_member_chain branch December 22, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant