Skip to content

fix(formatter): trailing comments of JSX in call arguments are moved out the of call#17255

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call
Dec 22, 2025
Merged

fix(formatter): trailing comments of JSX in call arguments are moved out the of call#17255
graphite-app[bot] merged 1 commit intomainfrom
12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 22, 2025

close: #17226

Copy link
Member Author

Dunqing commented Dec 22, 2025

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #17255 will not alter performance

Comparing 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call (173fb14) with 12-22-fix_formatter_should_expand_call_arguments_group_when_the_argument_will_break (95782ac)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing marked this pull request as ready for review December 22, 2025 08:00
@Dunqing Dunqing requested a review from leaysgur December 22, 2025 08:00
Boshen
Boshen previously requested changes Dec 22, 2025
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@Dunqing Dunqing force-pushed the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch from a87a619 to 173fb14 Compare December 22, 2025 08:31
@Dunqing
Copy link
Member Author

Dunqing commented Dec 22, 2025

Tests?

I forgot it🥲

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 22, 2025
@graphite-app graphite-app bot changed the base branch from 12-22-fix_formatter_should_expand_call_arguments_group_when_the_argument_will_break to graphite-base/17255 December 22, 2025 09:07
@graphite-app graphite-app bot force-pushed the graphite-base/17255 branch from 95782ac to c83f90c Compare December 22, 2025 09:20
@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch from 173fb14 to 0311b3b Compare December 22, 2025 09:20
@graphite-app graphite-app bot changed the base branch from graphite-base/17255 to main December 22, 2025 09:21
@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch from 0311b3b to 63e2659 Compare December 22, 2025 09:21
@Dunqing Dunqing dismissed Boshen’s stale review December 22, 2025 09:39

Added a test

@Dunqing Dunqing added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Dec 22, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 22, 2025

Merge activity

Copilot AI review requested due to automatic review settings December 22, 2025 09:46
@graphite-app graphite-app bot force-pushed the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch from 63e2659 to 6ad3951 Compare December 22, 2025 09:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 6ad3951 into main Dec 22, 2025
20 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 22, 2025
@graphite-app graphite-app bot deleted the 12-22-fix_formatter_trailing_comments_of_jsx_in_call_arguments_are_moved_out_the_of_call branch December 22, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formatter: Diff with Prettier on function called with JSX argument followed by commented argument

4 participants