fix(formatter): should expand call arguments group when the argument will break#17254
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 22, 2025
Conversation
This was referenced Dec 22, 2025
Member
Author
CodSpeed Performance ReportMerging #17254 will not alter performanceComparing Summary
Footnotes
|
Contributor
Merge activity
|
…will break (#17254) Fix an incorrect output that was found in #17252 (comment) Biome has the same incorrect output and ended up fixing it by aligning the [Prettier implementation](https://github.com/prettier/prettier/blob/0273e33fc691e28e4ab3f3c8ee86918b65cf823d/src/language-js/print/call-arguments.js#L193-L195).
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
…here is a leading line comment (#17252) close: #16902 The case below's output is incorrect, but it's not related to this issue, and was fixed in #17254 Input ```ts console.log( < // comment string | number | undefined >0 ); ``` Expect output: ```ts console.log( < // comment string | number | undefined >0 ); ``` Actual output ```ts console.log(< // comment string | number | undefined >0); ```
graphite-app
bot
force-pushed
the
12-22-fix_formatter_wrongly_added_an_indentation_for_an_union_type_when_there_is_a_leading_line_comment
branch
from
39a5ee2 to
def4ec1
Compare
graphite-app
bot
force-pushed
the
12-22-fix_formatter_should_expand_call_arguments_group_when_the_argument_will_break
branch
from
95782ac to
c83f90c
Compare
Base automatically changed from
12-22-fix_formatter_wrongly_added_an_indentation_for_an_union_type_when_there_is_a_leading_line_comment
to
main
December 22, 2025 09:17
graphite-app
bot
deleted the
12-22-fix_formatter_should_expand_call_arguments_group_when_the_argument_will_break
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an incorrect output that was found in #17252 (comment)
Biome has the same incorrect output and ended up fixing it by aligning the Prettier implementation.