fix(formatter): method signature missed a semicolon when it is on the same line with a property

[Dunqing]

close: #17151

[Dunqing]

• fix(formatter): should treat TSMappedType as a complex type in assignment-like formatting #17257
• fix(formatter): shouldn't treat TaggedTemplateExpression as a simple argument in the member chain #17256
• fix(formatter): trailing comments of JSX in call arguments are moved out the of call #17255
• fix(formatter): should expand call arguments group when the argument will break #17254
• fix(formatter): wrongly added an indentation for an union type when there is a leading line comment #17252
• test(formatter): move react hooks related tests to a same folder #17247
• fix(formatter): diff with Prettier on hook with spread arguments function #17246
• fix(formatter): shorthand property broken with consistent quote props #17245
• fix(formatter): method signature missed a semicolon when it is on the same line with a property #17243 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17243 will not alter performance

_{Comparing 12-22-fix_formatter_method_signature_missed_a_semicolon_when_it_is_on_the_same_line_with_a_property (54d12e5) with main (e08fdf1)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on main (879601e) during the generation of this report, so e08fdf1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes a formatter issue where method signatures were missing semicolons when appearing on the same line as a property in TypeScript type definitions. The fix refactors the semicolon insertion logic to be more maintainable while preserving the original behavior.

• Refactored the Semicolons::AsNeeded logic from an early-return pattern to a more concise matches! expression
• Added test cases demonstrating method signatures and properties on the same line
• Updated test snapshots to reflect the correct formatting behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_formatter/src/write/mod.rs	Refactored semicolon insertion logic in FormatTSSignature::fmt to use matches! macro instead of early return pattern, improving code maintainability
crates/oxc_formatter/tests/fixtures/ts/semi/method-signatures.ts	Added test case with union type containing method signatures and properties on the same line
crates/oxc_formatter/tests/fixtures/ts/semi/method-signatures.ts.snap	Updated snapshot to include expected formatting output for the new test case across different configurations

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Boshen]

How come there were no existing test failures? An idempotent test should've caught this somewhere.

[leaysgur]

https://github.com/prettier/prettier/blob/0b16f5d33936b83db5cb87e9b7b8755040f4af06/tests/format/typescript/interface/no-semi/14040.ts#L77-L80

According to my quick research, this is the most relevant Prettier test case.

However, since the method signature in question is located at the end, it was not detected.
(In other words, it wasn't even tested in Prettier.)

[Dunqing]

How come there were no existing test failures? An idempotent test should've caught this somewhere.

#17151 (comment)

[graphite-app]

Merge activity

• Dec 22, 9:04 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Dec 22, 9:10 AM UTC: Merged by the Graphite merge queue.