Skip to content

Comments

fix(oxlint/lsp): report diagnostics referencing another file#16715

Closed
Sysix wants to merge 1 commit intomainfrom
12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file
Closed

fix(oxlint/lsp): report diagnostics referencing another file#16715
Sysix wants to merge 1 commit intomainfrom
12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 10, 2025

grafik

Mostly created with GPT5 🤖

Copy link
Member Author

Sysix commented Dec 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-bug Category - Bug labels Dec 10, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #16715 will not alter performance

Comparing 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file (e010485) with main (fc96ee0)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch from e1877fb to ac5b7ee Compare December 10, 2025 22:46
@Sysix Sysix force-pushed the 12-09-refactor_oxlint_lsp_accept_multiple_files_inside_lintrunner_ branch from 87ba840 to fabb716 Compare December 10, 2025 22:46
@Sysix Sysix force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch 2 times, most recently from 7fc8435 to a0bd7e4 Compare December 11, 2025 00:10
@camc314 camc314 self-assigned this Dec 11, 2025
@Sysix Sysix force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch from a0bd7e4 to bf998de Compare December 12, 2025 14:07
@graphite-app graphite-app bot force-pushed the 12-09-refactor_oxlint_lsp_accept_multiple_files_inside_lintrunner_ branch 2 times, most recently from 9c5b63f to 4ed7478 Compare December 13, 2025 12:45
@graphite-app graphite-app bot force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch from bf998de to d4955a3 Compare December 13, 2025 12:45
@Sysix Sysix force-pushed the 12-09-refactor_oxlint_lsp_accept_multiple_files_inside_lintrunner_ branch from 4ed7478 to 584400d Compare December 14, 2025 16:08
@Sysix Sysix force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch 3 times, most recently from b1ecab0 to dc39951 Compare December 14, 2025 18:58
@Sysix
Copy link
Member Author

Sysix commented Dec 15, 2025

@camc314 do you know if tsgolint accept tsconfig.json as an input file?
My current problem: file.ts triggers a diagnostics for tsconfig.json file.
The user fixes the diagnostic in tsconfig.json, but there is no re-linting done for the tsconfig.json.
The error will still be shown, even if file.ts or tsconfig.json is modified again.

Another problem: Having 2 TS files reporting the same tsconfig.json diagnostic.
I need probably to lookup how the TS language server is handling this kind of cross-file diagnostics :/

@camc314
Copy link
Contributor

camc314 commented Dec 16, 2025

Can I just use this branch?

I think this probably works with SourceOverrides but i would need to test it

@graphite-app graphite-app bot changed the base branch from 12-09-refactor_oxlint_lsp_accept_multiple_files_inside_lintrunner_ to graphite-base/16715 December 16, 2025 11:55
@graphite-app graphite-app bot force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch from dc39951 to 8c5bbcc Compare December 16, 2025 12:01
@graphite-app graphite-app bot force-pushed the graphite-base/16715 branch from 584400d to fc96ee0 Compare December 16, 2025 12:01
@graphite-app graphite-app bot changed the base branch from graphite-base/16715 to main December 16, 2025 12:02
@graphite-app graphite-app bot force-pushed the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch from 8c5bbcc to e010485 Compare December 16, 2025 12:02
@Sysix
Copy link
Member Author

Sysix commented Dec 16, 2025

Can I just use this branch?

Sure :) Keep in mind that the VSCode extension does not send didOpen/didChange/didSave notification to the server for now.

const supportedExtensions = [
"astro",
"cjs",
"cts",
"js",
"jsx",
"mjs",
"mts",
"svelte",
"ts",
"tsx",
"vue",
];

@Sysix
Copy link
Member Author

Sysix commented Dec 20, 2025

Maybe we should wait for the implementation of textDocument/diagnostic. Its response can have related document diagnostics: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#relatedFullDocumentDiagnosticReport

@Sysix
Copy link
Member Author

Sysix commented Dec 26, 2025

With related document diagnostics, it will not be shown inside VS Code editor, do not know how other editor handle this :/

@Sysix Sysix closed this Feb 13, 2026
@Sysix Sysix deleted the 12-10-fix_oxlint_lsp_report_diagnostics_referencing_another_file branch February 13, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants