Skip to content

Comments

fix(lsp): shutdown a WorkspaceWorker will clear diagnostics for all known files#16467

Closed
Sysix wants to merge 1 commit intomainfrom
12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files
Closed

fix(lsp): shutdown a WorkspaceWorker will clear diagnostics for all known files#16467
Sysix wants to merge 1 commit intomainfrom
12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 3, 2025

No description provided.

Copy link
Member Author

Sysix commented Dec 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix force-pushed the 12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files branch from 56efa04 to cd591ca Compare December 3, 2025 21:05
@Sysix
Copy link
Member Author

Sysix commented Dec 3, 2025

@copilot the tests test_diagnostic_on_* and test_code_actions_* are sometimes passing and sometimes not.
Can you find the problem?

@Sysix Sysix changed the base branch from 12-02-fix_oxlint_lsp_revalidate_all_known_files_after_internal_restart to graphite-base/16467 December 3, 2025 21:49
@Sysix Sysix changed the base branch from graphite-base/16467 to 12-02-fix_oxlint_lsp_revalidate_all_known_files_after_internal_restart December 3, 2025 21:49
@Sysix Sysix changed the base branch from 12-02-fix_oxlint_lsp_revalidate_all_known_files_after_internal_restart to graphite-base/16467 December 3, 2025 21:49
@Sysix Sysix force-pushed the graphite-base/16467 branch from 5e95306 to 39701eb Compare December 3, 2025 21:49
@Sysix Sysix force-pushed the 12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files branch from cd591ca to 37573a7 Compare December 3, 2025 21:49
@Sysix Sysix changed the base branch from graphite-base/16467 to 12-03-perf_lsp_avoid_uri_to_string_and_back_to_uri_conversion December 3, 2025 21:50
@graphite-app graphite-app bot changed the base branch from 12-03-perf_lsp_avoid_uri_to_string_and_back_to_uri_conversion to graphite-base/16467 December 3, 2025 22:40
@graphite-app graphite-app bot force-pushed the graphite-base/16467 branch from 39701eb to 0ca9754 Compare December 3, 2025 22:46
@graphite-app graphite-app bot force-pushed the 12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files branch from 37573a7 to c610087 Compare December 3, 2025 22:46
@graphite-app graphite-app bot changed the base branch from graphite-base/16467 to main December 3, 2025 22:47
@graphite-app graphite-app bot force-pushed the 12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files branch from c610087 to 33ba75c Compare December 3, 2025 22:47
@Sysix Sysix force-pushed the 12-03-fix_lsp_shutdown_a_workspaceworker_will_clear_diagnostics_for_all_known_files branch from 33ba75c to e68b589 Compare December 5, 2025 17:06
@camc314 camc314 self-assigned this Dec 10, 2025
@Sysix
Copy link
Member Author

Sysix commented Dec 25, 2025

With #16715 and the pull diagnostic mode, I am not sure if I should check for fs files, instead of diagnostic/code-actions files.
Because pull mode is preferred, the diagnostic handling is moved to the client and we are not responsible to clear it :)

@Sysix Sysix closed this Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants