refactor(oxlint/lsp): use fs as param in TsGoLintState, instead of source text

[Sysix]

In the future, the language server wants to lint multiple files at the same time.
Refactored the code to accept the RuntimeFS (like the CLI tool) for reading the source text.

[Sysix]

• fix(oxlint/lsp): report diagnostics referencing another file #16715
• refactor(oxlint/lsp): accept multiple files inside LintRunner #16668
• refactor(oxlint/lsp): use fs as param in TsGoLintState, instead of source text #16667 👈 (View in Graphite)
• refactor(oxlint/lsp): IsolatedLintHandlerFileSystem is now a FxHashMap #16666
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16667 will not alter performance

_{Comparing 12-09-refactor_linter_use_file_system_as_param_instead_of_source_text (dd22b62) with main (0740016)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on 12-09-refactor_oxlint_lsp_isolatedlinthandlerfilesystem_is_now_a_fxhasmap_ (0e13f34) during the generation of this report, so main (0740016) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR refactors the TsGoLintState::lint_source method and its caller LintRunner::run_source to accept a file system parameter instead of source text. This change aligns the API design by delegating file reading responsibility to the function itself rather than requiring callers to provide the source text.

Key changes:

• Modified TsGoLintState::lint_source to accept file_system parameter instead of source_text parameter
• Updated LintRunner::run_source signature to remove source_text parameter
• Updated IsolatedLintHandler to call run_source without passing source text

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/tsgolint.rs	Refactored lint_source to accept file system parameter and read file internally using arena allocator, then convert to owned String
crates/oxc_linter/src/lint_runner.rs	Removed source_text parameter from run_source signature and updated call to lint_source
crates/oxc_language_server/src/linter/isolated_lint_handler.rs	Updated caller to remove source_text argument from run_source call

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[charliecreates]

The refactor is directionally good, but TsGoLintState::lint_source now does extra allocations (Allocator + to_string() + cloning) and loses useful error context by not including the underlying read error. Also, the pipeline likely reads the same file twice (regular + type-aware lint), which can become a real performance issue when scaling to multi-file linting.

Summary of changes

Summary of changes

• Refactored the language-server lint flow to pass a RuntimeFileSystem into linting instead of passing source_text through the API.
• Updated LintRunner::run_source to remove the source_text: String parameter and forward the file_system to the type-aware linter.
• Updated TsGoLintState::lint_source to read the source from file_system via read_to_arena_str (using oxc_allocator::Allocator) and to use an owned String (source_text_owned) inside the spawned thread.

[camc314]

Merge activity

• Dec 13, 12:35 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 13, 12:35 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 13, 12:43 PM UTC: Merged by the Graphite merge queue.