refactor(oxlint/lsp): accept multiple files inside LintRunner#16668
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #16668 will not alter performanceComparing Summary
Footnotes
|
4e25873 to
87ba840
Compare
17dd958 to
aee5bc6
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the linting infrastructure to accept multiple files in the LintRunner and TsGoLintState APIs. While the language server currently still sends only one file at a time, the underlying infrastructure now supports batch processing of multiple files, preparing for future enhancements.
Key Changes
- Modified
LintRunner::run_source()to accept&[Arc<OsStr>]instead of a single file - Updated
TsGoLintState::lint_source()to handle multiple files by reading all sources into a map and processing them together - Updated the isolated lint handler call site to use array syntax
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/oxc_linter/src/lint_runner.rs |
Changed run_source() parameter from single file to files slice and updated calls to type-aware linter |
crates/oxc_linter/src/tsgolint.rs |
Refactored lint_source() to loop through multiple paths, reading all sources into an override map for batch processing |
crates/oxc_language_server/src/linter/isolated_lint_handler.rs |
Updated call site to wrap single path in array syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aee5bc6 to
dd22b62
Compare
87ba840 to
fabb716
Compare
fabb716 to
9c5b63f
Compare
dd22b62 to
73da317
Compare
9c5b63f to
4ed7478
Compare
4ed7478 to
584400d
Compare
Merge activity
|
The Isolated linter from the language server stills sends only one file at the moment, but everything is ready to accept multiple files at the same time :)
584400d to
3e778fb
Compare
…project#16668) The Isolated linter from the language server stills sends only one file at the moment, but everything is ready to accept multiple files at the same time :)

The Isolated linter from the language server stills sends only one file at the moment, but everything is ready to accept multiple files at the same time :)