feat(minifier): use is_literal_value in substitute_single_use_symbol_in_expression#13364
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 29, 2025
Conversation
This was referenced Aug 28, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13364 will degrade performances by 10.14%Comparing Summary
Benchmarks breakdown
Footnotes |
b4ddb2b to
f6673bb
Compare
f6673bb to
18c3c8e
Compare
23542e9 to
bb25bcc
Compare
18c3c8e to
ddcb374
Compare
bb25bcc to
3f346e3
Compare
Member
Merge activity
|
…ol_in_expression` (#13364) Use `is_literal_value` instead of `is_literal` to allow more cases to be inlined.
3f346e3 to
ac2067b
Compare
ddcb374 to
a40140a
Compare
Base automatically changed from
08-29-feat_ecmascript_examine_and_improve_is_literal_value_
to
main
August 29, 2025 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use
is_literal_valueinstead ofis_literalto allow more cases to be inlined.