Skip to content

Comments

feat(minifier): use is_literal_value in substitute_single_use_symbol_in_expression#13364

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_
Aug 29, 2025
Merged

feat(minifier): use is_literal_value in substitute_single_use_symbol_in_expression#13364
graphite-app[bot] merged 1 commit intomainfrom
08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2025

Use is_literal_value instead of is_literal to allow more cases to be inlined.

Copy link
Member Author

sapphi-red commented Aug 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Instrumentation Performance Report

Merging #13364 will degrade performances by 10.14%

Comparing 08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_ (a40140a) with main (72468f9)1

Summary

❌ 2 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.6 µs 15.1 µs -3.39%
mangler[cal.com.tsx] 3 ms 3.4 ms -10.14%

Footnotes

  1. No successful run was found on main (a40140a) during the generation of this report, so 72468f9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red force-pushed the 08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_ branch from b4ddb2b to f6673bb Compare August 28, 2025 18:05
@sapphi-red sapphi-red marked this pull request as ready for review August 28, 2025 18:05
@sapphi-red sapphi-red force-pushed the 08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_ branch from f6673bb to 18c3c8e Compare August 28, 2025 18:11
@sapphi-red sapphi-red force-pushed the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch from 23542e9 to bb25bcc Compare August 28, 2025 18:11
@sapphi-red sapphi-red force-pushed the 08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_ branch from 18c3c8e to ddcb374 Compare August 28, 2025 18:17
@sapphi-red sapphi-red force-pushed the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch from bb25bcc to 3f346e3 Compare August 28, 2025 18:17
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
Copy link
Member

Boshen commented Aug 29, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
…ol_in_expression` (#13364)

Use `is_literal_value` instead of `is_literal` to allow more cases to be inlined.
@graphite-app graphite-app bot force-pushed the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch from 3f346e3 to ac2067b Compare August 29, 2025 02:55
@graphite-app graphite-app bot force-pushed the 08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_ branch from ddcb374 to a40140a Compare August 29, 2025 02:56
Base automatically changed from 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ to main August 29, 2025 03:00
@graphite-app graphite-app bot merged commit a40140a into main Aug 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-29-feat_minifier_use_is_literal_value_in_substitute_single_use_symbol_in_expression_ branch August 29, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants