Skip to content

feat(minifier): inline top-level variables for module scripts#13361

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-29-feat_minifier_inline_top-level_variables_for_module_scripts
Aug 29, 2025
Merged

feat(minifier): inline top-level variables for module scripts#13361
graphite-app[bot] merged 1 commit intomainfrom
08-29-feat_minifier_inline_top-level_variables_for_module_scripts

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2025

For module scripts, top-level variables can also be inlined, unless that variable is exported.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Aug 28, 2025
Copy link
Member Author

sapphi-red commented Aug 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Instrumentation Performance Report

Merging #13361 will not alter performance

Comparing 08-29-feat_minifier_inline_top-level_variables_for_module_scripts (56d2da3) with main (b53a294)1

Summary

✅ 38 untouched benchmarks

Footnotes

  1. No successful run was found on main (56d2da3) during the generation of this report, so b53a294 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

For module scripts, top-level variables can also be inlined, unless that variable is exported.
@graphite-app graphite-app bot force-pushed the 08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests branch from 3c0a4be to d0f1d63 Compare August 29, 2025 02:47
@graphite-app graphite-app bot force-pushed the 08-29-feat_minifier_inline_top-level_variables_for_module_scripts branch from fe63e95 to 56d2da3 Compare August 29, 2025 02:48
Base automatically changed from 08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests to main August 29, 2025 02:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app graphite-app bot merged commit 56d2da3 into main Aug 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-29-feat_minifier_inline_top-level_variables_for_module_scripts branch August 29, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant