Skip to content

Comments

test(minifier): share test helper functions between unit tests and integration tests#13360

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests
Aug 29, 2025
Merged

test(minifier): share test helper functions between unit tests and integration tests#13360
graphite-app[bot] merged 1 commit intomainfrom
08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2025

To reduce duplicated code.

@github-actions github-actions bot added the A-minifier Area - Minifier label Aug 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Instrumentation Performance Report

Merging #13360 will improve performances by 11.1%

Comparing 08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests (d0f1d63) with main (b53a294)1

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.3 ms 3 ms +11.1%

Footnotes

  1. No successful run was found on main (d0f1d63) during the generation of this report, so b53a294 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

Copilot AI review requested due to automatic review settings August 29, 2025 02:47
@graphite-app graphite-app bot force-pushed the 08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests branch from 3c0a4be to d0f1d63 Compare August 29, 2025 02:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit d0f1d63 into main Aug 29, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app graphite-app bot deleted the 08-29-test_minifier_share_test_helper_functions_between_unit_tests_and_integration_tests branch August 29, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant