Skip to content

Comments

feat(ecmascript): examine and improve is_literal_value#13363

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-29-feat_ecmascript_examine_and_improve_is_literal_value_
Aug 29, 2025
Merged

feat(ecmascript): examine and improve is_literal_value#13363
graphite-app[bot] merged 1 commit intomainfrom
08-29-feat_ecmascript_examine_and_improve_is_literal_value_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2025

Rewrote IsLiteralValue completely to ensure it satisfies the condition written in the description. Also added a bunch of tests for it.

Copy link
Member Author

sapphi-red commented Aug 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Instrumentation Performance Report

Merging #13363 will degrade performances by 10.54%

Comparing 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ (ac2067b) with main (72468f9)1

Summary

❌ 2 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.6 µs 15.1 µs -3.01%
mangler[cal.com.tsx] 3 ms 3.4 ms -10.54%

Footnotes

  1. No successful run was found on main (ac2067b) during the generation of this report, so 72468f9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red force-pushed the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch from 23542e9 to bb25bcc Compare August 28, 2025 18:11
@sapphi-red sapphi-red force-pushed the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch from bb25bcc to 3f346e3 Compare August 28, 2025 18:17
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 08-29-fix_minifier_keep_variables_that_are_modified_by_typeof_foo_object_foo_null_compression_2_ to graphite-base/13363 August 29, 2025 02:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/13363 to main August 29, 2025 02:54
Rewrote `IsLiteralValue` completely to ensure it satisfies the condition written in the description. Also added a bunch of tests for it.
@graphite-app graphite-app bot force-pushed the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch from 3f346e3 to ac2067b Compare August 29, 2025 02:55
@graphite-app graphite-app bot merged commit ac2067b into main Aug 29, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-29-feat_ecmascript_examine_and_improve_is_literal_value_ branch August 29, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant