feat(ecmascript): examine and improve is_literal_value#13363
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 29, 2025
Merged
Conversation
This was referenced Aug 28, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13363 will degrade performances by 10.54%Comparing Summary
Benchmarks breakdown
Footnotes |
23542e9 to
bb25bcc
Compare
bb25bcc to
3f346e3
Compare
Contributor
Merge activity
|
Rewrote `IsLiteralValue` completely to ensure it satisfies the condition written in the description. Also added a bunch of tests for it.
3f346e3 to
ac2067b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rewrote
IsLiteralValuecompletely to ensure it satisfies the condition written in the description. Also added a bunch of tests for it.