refactor(linter): avoid unnecessary var initialization

[overlookmotel]

Further refactor of process_path, continuing from #13070.

Avoid unnecessary pre-initialization of records and module_content, when mostly they're overwritten later. Instead, each branch of the if / else hold their own vars, and construct a ProcessedModule.

There may be some tiny perf benefit of skipping the initializations, but mainly motivation is to make it more explicit what each branch returns, which personally I find makes the logic easier to follow.

Also de-duplicate creation of allocator_guard, which was previously repeated in both branches.

[overlookmotel]

• refactor(linter): rename var for consistency #13074
• refactor(linter): dereference Allocator from AllocatorGuard #13073
• refactor(linter): avoid unnecessary var initialization #13072 👈 (View in Graphite)
• refactor(linter): reduce repeated code #13070
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13072 will not alter performance

_{Comparing 08-13-refactor_linter_avoid_unnecessary_var_initialization (1d77d92) with main (1c15288)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on main (1d77d92) during the generation of this report, so 1c15288 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[camc314]

Merge activity

• Aug 14, 11:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 14, 11:58 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Aug 14, 12:05 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
• Aug 14, 8:10 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 14, 8:52 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Aug 14, 8:57 PM UTC: Merged by the Graphite merge queue.

[camc314]

@overlookmotel graphite has done something wierd and this has ended up with conflicts

[Copilot]

Pull Request Overview

This refactor improves the process_path method by eliminating unnecessary variable pre-initialization and making the control flow more explicit. The changes move variable declarations closer to their usage and consolidate duplicated allocator guard creation.

• Removed pre-initialization of records and module_content variables
• Moved variable declarations into their respective if/else branches
• Consolidated allocator_guard creation to avoid duplication

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}