Skip to content

refactor(linter): avoid unnecessary var initialization #13072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 14, 2025
Merged

refactor(linter): avoid unnecessary var initialization #13072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions crates/oxc_linter/src/service/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,13 +887,13 @@ impl Runtime {
return None;
}

let mut records = SmallVec::<[Result<ResolvedModuleRecord, Vec<OxcDiagnostic>>; 1]>::new();
let mut module_content: Option<ModuleContent> = None;
let allocator_guard = self.allocator_pool.get();

if self.paths.contains(path) {
let allocator_guard = self.allocator_pool.get();
let mut records =
SmallVec::<[Result<ResolvedModuleRecord, Vec<OxcDiagnostic>>; 1]>::new();

let mc = ModuleContent::try_new(allocator_guard, |allocator| {
let module_content = ModuleContent::try_new(allocator_guard, |allocator| {
let Some(stt) = self.get_source_type_and_text(Path::new(path), ext, allocator)
else {
return Err(());
Expand All @@ -920,11 +920,10 @@ impl Runtime {

Ok(ModuleContentDependent { source_text, section_contents })
});
let mc = mc.ok()?;
let module_content = module_content.ok()?;

module_content = Some(mc);
Some(ProcessedModule { section_module_records: records, content: Some(module_content) })
} else {
let allocator_guard = self.allocator_pool.get();
let allocator = &*allocator_guard;

let stt = self.get_source_type_and_text(Path::new(path), ext, allocator)?;
Expand All @@ -937,7 +936,7 @@ impl Runtime {
}
};

records = self.process_source(
let records = self.process_source(
Path::new(path),
ext,
check_syntax_errors,
Expand All @@ -946,9 +945,9 @@ impl Runtime {
allocator,
None,
);
}

Some(ProcessedModule { section_module_records: records, content: module_content })
Some(ProcessedModule { section_module_records: records, content: None })
}
}

#[expect(clippy::too_many_arguments)]
Expand Down
Loading