Skip to content

refactor(linter): rename var for consistency#13074

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-13-refactor_linter_rename_var_for_consistency
Aug 14, 2025
Merged

refactor(linter): rename var for consistency#13074
graphite-app[bot] merged 1 commit intomainfrom
08-13-refactor_linter_rename_var_for_consistency

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 13, 2025

Nit. Rename var to tx_process_output for consistency with everywhere else in this function.

I assume the var was previously called tx_resolve_output everywhere, and this one slipped through the net when renaming the rest.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 13, 2025
Copy link
Member Author

overlookmotel commented Aug 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 13, 2025

CodSpeed Instrumentation Performance Report

Merging #13074 will not alter performance

Comparing 08-13-refactor_linter_rename_var_for_consistency (0453ee3) with main (1c15288)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (0453ee3) during the generation of this report, so 1c15288 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the 08-13-refactor_linter_rename_var_for_consistency branch from 33eb05d to a3fdd67 Compare August 14, 2025 20:09
@overlookmotel overlookmotel force-pushed the 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ branch from 93e140c to dbbd9c9 Compare August 14, 2025 20:09
@overlookmotel
Copy link
Member Author

Only renames a var, so I don't think much need for review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
@overlookmotel overlookmotel removed the request for review from camc314 August 14, 2025 20:11
Copy link
Member Author

overlookmotel commented Aug 14, 2025

Merge activity

  • Aug 14, 8:11 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 8:11 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 8:52 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 14, 8:58 PM UTC: Merged by the Graphite merge queue.

Nit. Rename var to `tx_process_output` for consistency with everywhere else in this function.

I assume the var was previously called `tx_resolve_output` everywhere, and this one slipped through the net when renaming the rest.
@graphite-app graphite-app bot force-pushed the 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ branch from dbbd9c9 to 5783df2 Compare August 14, 2025 20:53
@graphite-app graphite-app bot force-pushed the 08-13-refactor_linter_rename_var_for_consistency branch from a3fdd67 to 0453ee3 Compare August 14, 2025 20:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Base automatically changed from 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ to main August 14, 2025 20:57
@graphite-app graphite-app bot merged commit 0453ee3 into main Aug 14, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-13-refactor_linter_rename_var_for_consistency branch August 14, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant