refactor(linter): reduce repeated code#13070
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 14, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13070 will not alter performanceComparing Summary
Footnotes |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This refactor simplifies the process_path method by extracting duplicated return logic into a separate helper function. The change eliminates multiple instances of creating default ModuleProcessOutput with cloned path values.
- Extracted core processing logic into
process_path_to_modulehelper function - Replaced multiple
default_output()calls with early returns using?operator - Simplified error handling flow by using
Option<ProcessedModule>return type
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Aug 13, 2025
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Refactor. Many branches of `process_path` return a default `ProcessedModule`. All branches return a `ModuleProcessOutput` with `path` field containing a clone of `path` param. Move the duplicated logic into a separate function, to allow shortening and simplifying the logic. There may be a small perf benefit of not repeating the same code in many places, but mainly the motivation is to shorten the code, which I find makes it a bit easier to understand.
graphite-app
bot
force-pushed
the
08-13-refactor_linter_reduce_repeated_code
branch
from
a0c16b9 to
103c51b
Compare
Refactor. Many branches of `process_path` return a default `ProcessedModule`. All branches return a `ModuleProcessOutput` with `path` field containing a clone of `path` param. Move the duplicated logic into a separate function, to allow shortening and simplifying the logic. There may be a small perf benefit of not repeating the same code in many places, but mainly the motivation is to shorten the code, which I find makes it a bit easier to understand.
graphite-app
bot
force-pushed
the
08-13-refactor_linter_reduce_repeated_code
branch
from
103c51b to
74fb6c9
Compare
graphite-app
bot
deleted the
08-13-refactor_linter_reduce_repeated_code
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Further refactor of `process_path`, continuing from #13070. Avoid unnecessary pre-initialization of `records` and `module_content`, when mostly they're overwritten later. Instead, each branch of the `if` / `else` hold their own vars, and construct a `ProcessedModule`. There may be some tiny perf benefit of skipping the initializations, but mainly motivation is to make it more explicit what each branch returns, which personally I find makes the logic easier to follow. Also de-duplicate creation of `allocator_guard`, which was previously repeated in both branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor. Many branches of
process_pathreturn a defaultProcessedModule. All branches return aModuleProcessOutputwithpathfield containing a clone ofpathparam.Move the duplicated logic into a separate function, to allow shortening and simplifying the logic.
There may be a small perf benefit of not repeating the same code in many places, but mainly the motivation is to shorten the code, which I find makes it a bit easier to understand.