Skip to content

Comments

refactor(semantic): move TSTypeQuery exit node handling to visit methods#12633

Closed
camc314 wants to merge 1 commit intoc/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methodsfrom
c/07-30-refactor_semantic_move_tstypequery_exit_node_handling_to_visit_methods
Closed

refactor(semantic): move TSTypeQuery exit node handling to visit methods#12633
camc314 wants to merge 1 commit intoc/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methodsfrom
c/07-30-refactor_semantic_move_tstypequery_exit_node_handling_to_visit_methods

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 30, 2025

No description provided.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 30, 2025
Copy link
Contributor Author

camc314 commented Jul 30, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review July 30, 2025 13:32
@camc314 camc314 requested a review from Dunqing as a code owner July 30, 2025 13:32
@camc314 camc314 changed the base branch from c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods to graphite-base/12633 July 30, 2025 13:37
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 30, 2025

CodSpeed Instrumentation Performance Report

Merging #12633 will not alter performance

Comparing c/07-30-refactor_semantic_move_tstypequery_exit_node_handling_to_visit_methods (4809d39) with main (109fc3c)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods (3924fd7) during the generation of this report, so main (109fc3c) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 force-pushed the c/07-30-refactor_semantic_move_tstypequery_exit_node_handling_to_visit_methods branch from 83e1e99 to f56f871 Compare July 30, 2025 15:10
@camc314 camc314 force-pushed the graphite-base/12633 branch from c890607 to 1d29607 Compare July 30, 2025 15:10
@camc314 camc314 changed the base branch from graphite-base/12633 to c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods July 30, 2025 15:11
@graphite-app graphite-app bot force-pushed the c/07-30-refactor_semantic_move_catchparameter_exit_node_handling_to_visit_methods branch 2 times, most recently from e483e40 to 3924fd7 Compare July 31, 2025 09:00
@graphite-app graphite-app bot force-pushed the c/07-30-refactor_semantic_move_tstypequery_exit_node_handling_to_visit_methods branch from f56f871 to 4809d39 Compare July 31, 2025 09:00
@camc314 camc314 closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant