refactor(semantic): move LabeledStatement exit node handling to visit methods#12635
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 31, 2025
Conversation
github-actions
bot
added
A-semantic
This was referenced Jul 30, 2025
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
force-pushed
the
c/07-30-refactor_semantic_move_labeledstatement_exit_node_handling_to_visit_methods
branch
from
83c5104 to
ac7a835
Compare
CodSpeed Instrumentation Performance ReportMerging #12635 will not alter performanceComparing Summary
|
camc314
changed the base branch from
c/07-30-refactor_semantic_move_tspropertysignature_exit_node_handling_to_visit_methods
to
graphite-base/12635
camc314
force-pushed
the
c/07-30-refactor_semantic_move_labeledstatement_exit_node_handling_to_visit_methods
branch
from
ac7a835 to
f24591c
Compare
camc314
force-pushed
the
graphite-base/12635
branch
from
20a761c to
4a37f76
Compare
camc314
changed the base branch from
graphite-base/12635
to
c/07-30-refactor_semantic_move_tspropertysignature_exit_node_handling_to_visit_methods
graphite-app
bot
force-pushed
the
c/07-30-refactor_semantic_move_tspropertysignature_exit_node_handling_to_visit_methods
branch
from
4a37f76 to
55eb74d
Compare
graphite-app
bot
force-pushed
the
c/07-30-refactor_semantic_move_labeledstatement_exit_node_handling_to_visit_methods
branch
from
f24591c to
50ed74c
Compare
camc314
changed the base branch from
c/07-30-refactor_semantic_move_tspropertysignature_exit_node_handling_to_visit_methods
to
graphite-base/12635
camc314
force-pushed
the
c/07-30-refactor_semantic_move_labeledstatement_exit_node_handling_to_visit_methods
branch
from
50ed74c to
c1fb4c7
Compare
camc314
force-pushed
the
graphite-base/12635
branch
from
55eb74d to
109fc3c
Compare
overlookmotel
approved these changes
Jul 31, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
Yes, in this case the code from leave_kind needs to go before leave_node.
Member
Merge activity
|
graphite-app
bot
force-pushed
the
c/07-30-refactor_semantic_move_labeledstatement_exit_node_handling_to_visit_methods
branch
from
c1fb4c7 to
bbc446f
Compare
graphite-app
bot
deleted the
c/07-30-refactor_semantic_move_labeledstatement_exit_node_handling_to_visit_methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.