Skip to content

Comments

refactor(semantic): add visit methods and move logic from enter_kind/leave_kind#12631

Closed
camc314 wants to merge 1 commit intoc/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methodsfrom
c/07-30-refactor_semantic_add_visit_methods_and_move_logic_from_enter_kind_leave_kind
Closed

refactor(semantic): add visit methods and move logic from enter_kind/leave_kind#12631
camc314 wants to merge 1 commit intoc/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methodsfrom
c/07-30-refactor_semantic_add_visit_methods_and_move_logic_from_enter_kind_leave_kind

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 30, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review July 30, 2025 13:26
@camc314 camc314 requested a review from Dunqing as a code owner July 30, 2025 13:26
@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 30, 2025
Copy link
Contributor Author

camc314 commented Jul 30, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 30, 2025

CodSpeed Instrumentation Performance Report

Merging #12631 will not alter performance

Comparing c/07-30-refactor_semantic_add_visit_methods_and_move_logic_from_enter_kind_leave_kind (e534a48) with c/07-30-refactor_semantic_move_function_and_arrowfunctionexpression_handling_to_visit_methods (76e6ef6)

Summary

✅ 34 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant