Skip to content

Comments

refactor(semantic): move AstKind::Class handling from leave_kind to visit_class#12629

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-30-refactor_semantic_move_astkind_class_handling_from_leave_kind_to_visit_class
Jul 31, 2025
Merged

refactor(semantic): move AstKind::Class handling from leave_kind to visit_class#12629
graphite-app[bot] merged 1 commit intomainfrom
c/07-30-refactor_semantic_move_astkind_class_handling_from_leave_kind_to_visit_class

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 30, 2025

Part of #18098.

@github-actions github-actions bot added the A-semantic Area - Semantic label Jul 30, 2025
@camc314 camc314 marked this pull request as ready for review July 30, 2025 13:24
@camc314 camc314 requested a review from Dunqing as a code owner July 30, 2025 13:24
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 30, 2025
Copy link
Contributor Author

camc314 commented Jul 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 30, 2025

CodSpeed Instrumentation Performance Report

Merging #12629 will not alter performance

Comparing c/07-30-refactor_semantic_move_astkind_class_handling_from_leave_kind_to_visit_class (8369bbd) with main (5ff286a)

Summary

✅ 34 untouched benchmarks

@camc314 camc314 force-pushed the c/07-30-refactor_semantic_move_astkind_class_handling_from_leave_kind_to_visit_class branch from 31c7384 to 404aa3c Compare July 30, 2025 14:45
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 31, 2025
Copy link
Member

overlookmotel commented Jul 31, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/07-30-refactor_semantic_move_astkind_class_handling_from_leave_kind_to_visit_class branch from 404aa3c to 8369bbd Compare July 31, 2025 08:39
@graphite-app graphite-app bot merged commit 8369bbd into main Jul 31, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 31, 2025
@graphite-app graphite-app bot deleted the c/07-30-refactor_semantic_move_astkind_class_handling_from_leave_kind_to_visit_class branch July 31, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants