Skip to content

feat(allocator): add Allocator::end_ptr method#12330

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-16-feat_allocator_add_allocator_end_ptr_method
Jul 18, 2025
Merged

feat(allocator): add Allocator::end_ptr method#12330
graphite-app[bot] merged 1 commit intomainfrom
07-16-feat_allocator_add_allocator_end_ptr_method

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 16, 2025

Add a method Allocator::end_ptr which returns a pointer to the end of the current chunk of an Allocator, after the ChunkFooter. For Allocators used for raw transfer, this pointer will point to the RawTransferMetadata which is stored after the allocator chunk.

Copy link
Member Author

overlookmotel commented Jul 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 16, 2025

CodSpeed Instrumentation Performance Report

Merging #12330 will not alter performance

Comparing 07-16-feat_allocator_add_allocator_end_ptr_method (de006a1) with 07-17-refactor_linter_pass_allocator_into_linter_run_external_rules_ (773fd88)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch 2 times, most recently from df1506e to 69e5cac Compare July 16, 2025 18:16
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from 3aa30f3 to 5ab9b4f Compare July 16, 2025 18:16
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from 5ab9b4f to eed6733 Compare July 16, 2025 18:44
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch 2 times, most recently from a3e15a9 to 9956c9a Compare July 17, 2025 04:15
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from eed6733 to 0da255f Compare July 17, 2025 04:15
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from 9956c9a to ed1c7b3 Compare July 17, 2025 09:20
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from 0da255f to c4deb74 Compare July 17, 2025 09:21
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch 2 times, most recently from 1aeb2ac to cb20b64 Compare July 17, 2025 14:58
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from c4deb74 to 03b1478 Compare July 17, 2025 14:59
@overlookmotel overlookmotel changed the base branch from 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s to graphite-base/12330 July 18, 2025 02:15
@overlookmotel overlookmotel changed the base branch from graphite-base/12330 to 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s July 18, 2025 02:16
@overlookmotel overlookmotel changed the base branch from 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s to graphite-base/12330 July 18, 2025 02:16
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from 03b1478 to ee0dd11 Compare July 18, 2025 02:16
@overlookmotel overlookmotel changed the base branch from graphite-base/12330 to 07-17-refactor_linter_pass_allocator_into_linter_run_external_rules_ July 18, 2025 02:16
@overlookmotel overlookmotel marked this pull request as ready for review July 18, 2025 02:23
Copy link
Contributor

camc314 commented Jul 18, 2025

Merge activity

Add a method `Allocator::end_ptr` which returns a pointer to the end of the current chunk of an `Allocator`, after the `ChunkFooter`. For `Allocator`s used for raw transfer, this pointer will point to the `RawTransferMetadata` which is stored after the allocator chunk.
@graphite-app graphite-app bot force-pushed the 07-17-refactor_linter_pass_allocator_into_linter_run_external_rules_ branch from 0caa0ea to 773fd88 Compare July 18, 2025 08:48
@graphite-app graphite-app bot requested a review from camc314 as a code owner July 18, 2025 08:48
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_add_allocator_end_ptr_method branch from d893563 to de006a1 Compare July 18, 2025 08:49
Base automatically changed from 07-17-refactor_linter_pass_allocator_into_linter_run_external_rules_ to main July 18, 2025 08:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025
@graphite-app graphite-app bot merged commit de006a1 into main Jul 18, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-16-feat_allocator_add_allocator_end_ptr_method branch July 18, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants