refactor(allocator): move all fixed size allocator code into 1 file by overlookmotel · Pull Request #12309 · oxc-project/oxc

overlookmotel · 2025-07-15T22:49:47Z

Pure refactor. Split AllocatorPool into 2 separate files for the normal and fixed size variants. The extra layer of abstraction required to share code between the two versions was getting unwieldy. All the fixed-size allocator code is now together in one file.

overlookmotel · 2025-07-15T22:50:03Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-15T22:55:04Z

CodSpeed Instrumentation Performance Report

Merging #12309 will not alter performance

_{Comparing 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file (dfe54b4) with main (b10ed11)}

Summary

✅ 34 untouched benchmarks

crates/oxc_allocator/src/pool_fixed_size.rs

overlookmotel · 2025-07-17T14:45:26Z

This PR is pure refactor, so I think it's good to merge. Still working on rest of the stack.

overlookmotel · 2025-07-17T16:59:16Z

Merge activity

Jul 17, 4:59 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 17, 4:59 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jul 17, 5:07 PM UTC: Merged by the Graphite merge queue.

…12309) Pure refactor. Split `AllocatorPool` into 2 separate files for the normal and fixed size variants. The extra layer of abstraction required to share code between the two versions was getting unwieldy. All the fixed-size allocator code is now together in one file.

overlookmotel mentioned this pull request Jul 15, 2025

ci(napi/oxlint): run tests with coverage profile #12308

Merged

github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 15, 2025

overlookmotel marked this pull request as ready for review July 15, 2025 22:53

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 6cbf927 to bb7b441 Compare July 15, 2025 22:54

overlookmotel mentioned this pull request Jul 16, 2025

feat(allocator): AllocatorPool store IDs in Allocators #12310

Merged

graphite-app bot changed the base branch from 07-15-ci_napi_oxlint_run_tests_with_coverage_profile to graphite-base/12309 July 16, 2025 10:40

graphite-app bot force-pushed the graphite-base/12309 branch from 5e89735 to 324eb2f Compare July 16, 2025 10:48

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from bb7b441 to 9264b16 Compare July 16, 2025 10:48

graphite-app bot changed the base branch from graphite-base/12309 to main July 16, 2025 10:49

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 9264b16 to bbf4b88 Compare July 16, 2025 10:49

graphite-app bot reviewed Jul 16, 2025

View reviewed changes

crates/oxc_allocator/src/pool_fixed_size.rs Show resolved Hide resolved

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from bbf4b88 to ca28d7d Compare July 16, 2025 15:33

overlookmotel mentioned this pull request Jul 16, 2025

feat(ast_tools): support Atomic* types in structs #12325

Merged

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from ca28d7d to 70f88fc Compare July 16, 2025 17:10

overlookmotel mentioned this pull request Jul 16, 2025

feat(allocator): add Allocator::end_ptr method #12330

Merged

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 70f88fc to 92280ab Compare July 16, 2025 18:44

overlookmotel marked this pull request as draft July 16, 2025 18:50

overlookmotel changed the base branch from main to graphite-base/12309 July 17, 2025 04:15

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 92280ab to b975b1e Compare July 17, 2025 04:15

overlookmotel changed the base branch from graphite-base/12309 to 07-17-fix_napi_oxlint_use_process.exitcode_ July 17, 2025 04:15

graphite-app bot changed the base branch from 07-17-fix_napi_oxlint_use_process.exitcode_ to graphite-base/12309 July 17, 2025 09:12

graphite-app bot force-pushed the graphite-base/12309 branch from 22bc769 to 98b17e9 Compare July 17, 2025 09:20

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from b975b1e to ec36d55 Compare July 17, 2025 09:20

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 1926f69 to f550279 Compare July 17, 2025 14:44

overlookmotel changed the base branch from graphite-base/12309 to 07-17-refactor_linter_make_unwrap_unconditional July 17, 2025 14:44

This was referenced Jul 17, 2025

refactor(linter): move running external rules into feature-gated function #12370

Merged

refactor(linter): make feature gates for oxlint2 feature consistent #12369

Merged

refactor(linter): make unwrap unconditional #12371

Merged

overlookmotel marked this pull request as ready for review July 17, 2025 14:44

graphite-app bot force-pushed the 07-17-refactor_linter_make_unwrap_unconditional branch from cf412a4 to 380e8f7 Compare July 17, 2025 14:57

graphite-app bot requested a review from camc314 as a code owner July 17, 2025 14:57

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from f550279 to 1d16b81 Compare July 17, 2025 14:57

overlookmotel force-pushed the 07-17-refactor_linter_make_unwrap_unconditional branch from 380e8f7 to 6b49bf8 Compare July 17, 2025 16:05

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch 2 times, most recently from 5699805 to bbed811 Compare July 17, 2025 16:23

overlookmotel force-pushed the 07-17-refactor_linter_make_unwrap_unconditional branch from 6b49bf8 to 279d2f3 Compare July 17, 2025 16:23

camc314 approved these changes Jul 17, 2025

View reviewed changes

overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from bbed811 to 98f3152 Compare July 17, 2025 16:38

overlookmotel force-pushed the 07-17-refactor_linter_make_unwrap_unconditional branch from 279d2f3 to 341b0df Compare July 17, 2025 16:38

graphite-app bot changed the base branch from 07-17-refactor_linter_make_unwrap_unconditional to graphite-base/12309 July 17, 2025 16:43

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 98f3152 to a5fa21c Compare July 17, 2025 16:46

graphite-app bot force-pushed the graphite-base/12309 branch from 341b0df to b10ed11 Compare July 17, 2025 16:46

graphite-app bot changed the base branch from graphite-base/12309 to main July 17, 2025 16:47

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from a5fa21c to b740bf9 Compare July 17, 2025 16:47

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 17, 2025

graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from b740bf9 to dfe54b4 Compare July 17, 2025 16:59

graphite-app bot merged commit dfe54b4 into main Jul 17, 2025
25 checks passed

graphite-app bot deleted the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch July 17, 2025 17:07

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 17, 2025

oxc-bot mentioned this pull request Jul 20, 2025

release(crates): v0.77.3 #12407

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(allocator): move all fixed size allocator code into 1 file#12309

refactor(allocator): move all fixed size allocator code into 1 file#12309
graphite-app[bot] merged 1 commit intomainfrom
07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file

overlookmotel commented Jul 15, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Jul 15, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

overlookmotel commented Jul 17, 2025

Uh oh!

overlookmotel commented Jul 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

overlookmotel commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12309 will not alter performance

Summary

Uh oh!

Uh oh!

overlookmotel commented Jul 17, 2025

Uh oh!

overlookmotel commented Jul 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Jul 15, 2025 •

edited

Loading

overlookmotel commented Jul 15, 2025 •

edited

Loading

codspeed-hq bot commented Jul 15, 2025 •

edited

Loading

overlookmotel commented Jul 17, 2025 •

edited by graphite-app bot

Loading