Skip to content

feat(allocator): AllocatorPool store IDs in Allocators#12310

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s
Jul 18, 2025
Merged

feat(allocator): AllocatorPool store IDs in Allocators#12310
graphite-app[bot] merged 1 commit intomainfrom
07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 16, 2025

Fixed size allocator pool give each Allocator a unique ID and store it in FixedSizeAllocatorMetadata struct at end of the buffer. This prepares the way for sharing buffers created on Rust side with JS while avoiding use-after-free or double-free.

Copy link
Member Author

overlookmotel commented Jul 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 16, 2025 00:14
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 16, 2025

CodSpeed Instrumentation Performance Report

Merging #12310 will not alter performance

Comparing 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s (bc0fbe5) with 07-17-refactor_allocator_fixed-size_store_alloc_ptr_in_the_memory_block_backing_the_allocator (319fc3b)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch 2 times, most recently from 9264b16 to bbf4b88 Compare July 16, 2025 10:49
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from 39b9a42 to 2935e46 Compare July 16, 2025 10:49
@overlookmotel overlookmotel changed the base branch from 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file to graphite-base/12310 July 16, 2025 15:33
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from 2935e46 to fd24afa Compare July 16, 2025 15:33
@overlookmotel overlookmotel changed the base branch from graphite-base/12310 to 07-16-feat_ast_tools_support_atomic_types_in_structs July 16, 2025 15:33
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from fd24afa to ba193f3 Compare July 16, 2025 17:10
@overlookmotel overlookmotel force-pushed the 07-16-feat_ast_tools_support_atomic_types_in_structs branch from e4e2888 to 19bd7a2 Compare July 16, 2025 17:10
@overlookmotel overlookmotel changed the base branch from 07-16-feat_ast_tools_support_atomic_types_in_structs to graphite-base/12310 July 16, 2025 17:54
@graphite-app graphite-app bot force-pushed the graphite-base/12310 branch from 19bd7a2 to fca2e84 Compare July 16, 2025 18:15
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from ba193f3 to df1506e Compare July 16, 2025 18:15
@graphite-app graphite-app bot changed the base branch from graphite-base/12310 to main July 16, 2025 18:16
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from df1506e to 69e5cac Compare July 16, 2025 18:16
@overlookmotel overlookmotel changed the base branch from main to graphite-base/12310 July 16, 2025 18:44
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from 69e5cac to a3e15a9 Compare July 16, 2025 18:44
@overlookmotel overlookmotel changed the base branch from graphite-base/12310 to 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file July 16, 2025 18:44
@overlookmotel overlookmotel marked this pull request as draft July 16, 2025 18:50
@overlookmotel overlookmotel force-pushed the 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file branch from 92280ab to b975b1e Compare July 17, 2025 04:15
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from a3e15a9 to 9956c9a Compare July 17, 2025 04:15
@graphite-app graphite-app bot force-pushed the graphite-base/12310 branch from 1926f69 to 1d16b81 Compare July 17, 2025 14:58
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from ed1c7b3 to 1aeb2ac Compare July 17, 2025 14:58
@graphite-app graphite-app bot changed the base branch from graphite-base/12310 to 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file July 17, 2025 14:58
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from 1aeb2ac to cb20b64 Compare July 17, 2025 14:58
@overlookmotel overlookmotel changed the base branch from 07-15-refactor_allocator_move_all_fixed_size_allocator_code_into_1_file to graphite-base/12310 July 17, 2025 16:05
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from cb20b64 to e21eeac Compare July 18, 2025 02:17
@overlookmotel overlookmotel changed the base branch from graphite-base/12310 to 07-17-refactor_allocator_fixed-size_store_alloc_ptr_in_the_memory_block_backing_the_allocator July 18, 2025 02:17
@overlookmotel overlookmotel marked this pull request as ready for review July 18, 2025 02:23
@overlookmotel overlookmotel changed the base branch from 07-17-refactor_allocator_fixed-size_store_alloc_ptr_in_the_memory_block_backing_the_allocator to graphite-base/12310 July 18, 2025 02:31
@overlookmotel overlookmotel force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from e21eeac to 43b0114 Compare July 18, 2025 02:31
@overlookmotel overlookmotel changed the base branch from graphite-base/12310 to 07-17-refactor_allocator_fixed-size_store_alloc_ptr_in_the_memory_block_backing_the_allocator July 18, 2025 02:31
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025
Copy link
Contributor

camc314 commented Jul 18, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 18, 2025
Fixed size allocator pool give each `Allocator` a unique ID and store it in `FixedSizeAllocatorMetadata` struct at end of the buffer. This prepares the way for sharing buffers created on Rust side with JS while avoiding use-after-free or double-free.
@graphite-app graphite-app bot force-pushed the 07-17-refactor_allocator_fixed-size_store_alloc_ptr_in_the_memory_block_backing_the_allocator branch from 6524307 to 319fc3b Compare July 18, 2025 09:00
@graphite-app graphite-app bot requested a review from camc314 as a code owner July 18, 2025 09:00
@graphite-app graphite-app bot force-pushed the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch from 43b0114 to bc0fbe5 Compare July 18, 2025 09:00
Base automatically changed from 07-17-refactor_allocator_fixed-size_store_alloc_ptr_in_the_memory_block_backing_the_allocator to main July 18, 2025 09:10
@graphite-app graphite-app bot merged commit bc0fbe5 into main Jul 18, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-16-feat_allocator_allocatorpool_store_ids_in_allocator_s branch July 18, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants