refactor(semantic): refactor check_binding_identifier

[overlookmotel]

Pure refactor. We had 2 if blocks following each other. 1st is if strict_mode && ... and the 2nd if !strict_mode && .... Convert into an if/else instead.

[overlookmotel]

• fix(semantic): disallow let as destructured catch param in sloppy mode #12306
• fix(semantic): allow let as arrow function param in sloppy mode #12305
• perf(semantic): reduce match arms in check_binding_identifier #12304
• refactor(semantic): refactor check_binding_identifier #12303 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camc314]

can we put this on top of the other stack? else I think there'll be merge conflicts.

#12298

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12303 will not alter performance

_{Comparing 07-15-refactor_semantic_refactor_check_binding_identifier_ (3c6b88b) with main (f9da2ca)}

Summary

✅ 34 untouched benchmarks

[graphite-app]

Merge activity

• Jul 16, 1:18 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Jul 16, 1:31 AM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
• Jul 16, 6:49 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 16, 6:49 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Jul 16, 7:00 PM UTC: Merged by the Graphite merge queue.

[Dunqing]

I guess you weren't aware of @camc314's comment. Consider this stack is a refactor or a kind of performance improvement, I am converting this PR to the draft and merging stack first, which blocks us from publishing new oxlint. I am sorry if this waste of your time.

[overlookmotel]

No problem. I'll rebase this now the other stack has been merged. I didn't see Cam's work before I did this.