fix(semantic): disallow let as destructured catch param in sloppy mode

[overlookmotel]

Fix check_binding_identifier to handle oddities around let bindings in catch params.

This is legal:

// Sloppy mode
try {} catch (let) {}

But these are syntax errors!

// Sloppy mode
try {} catch ( { let } ) {}
try {} catch ( [ let ] ) {}

[overlookmotel]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(semantic): disallow let as destructured catch param in sloppy mode #12306 👈 (View in Graphite)
• fix(semantic): allow let as arrow function param in sloppy mode #12305
• perf(semantic): reduce match arms in check_binding_identifier #12304
• refactor(semantic): refactor check_binding_identifier #12303
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12306 will not alter performance

_{Comparing 07-15-fix_semantic_disallow_let_as_destructured_catch_param_in_sloppy_mode (da820b9) with main (3c6b88b)}

Summary

✅ 34 untouched benchmarks

[overlookmotel]

I think this is right, but I only based it on observing what NodeJS does. Need to find the part of the spec that covers this and check NodeJS/V8 is right.