perf(semantic): reduce match arms in check_binding_identifier#12304
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 16, 2025
Merged
Conversation
github-actions
bot
added
A-semantic
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12304 will not alter performanceComparing Summary
|
This was referenced Jul 15, 2025
Member
Merge activity
|
overlookmotel
force-pushed
the
07-15-perf_semantic_reduce_match_arms_in_check_binding_identifier_
branch
from
9d37edc to
f5e99a8
Compare
overlookmotel
force-pushed
the
07-15-refactor_semantic_refactor_check_binding_identifier_
branch
from
6d0c3d1 to
00c24f1
Compare
Small optimization. 1. First arm match on `VariableDeclarator`, instead of `VariableDeclaration` - requires 1 less iteration to get to. 2. Remove match for `Program`. There's no point as iterator does that check on each turn of the loop anyway.
graphite-app
bot
force-pushed
the
07-15-refactor_semantic_refactor_check_binding_identifier_
branch
from
00c24f1 to
3c6b88b
Compare
graphite-app
bot
force-pushed
the
07-15-perf_semantic_reduce_match_arms_in_check_binding_identifier_
branch
from
f5e99a8 to
b60d63b
Compare
Base automatically changed from
07-15-refactor_semantic_refactor_check_binding_identifier_
to
main
July 16, 2025 19:00
graphite-app
bot
deleted the
07-15-perf_semantic_reduce_match_arms_in_check_binding_identifier_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization.
VariableDeclarator, instead ofVariableDeclaration- requires 1 less iteration to get to.Program. There's no point as iterator does that check on each turn of the loop anyway.