Skip to content

test(semantic): add failing tests for arguments and eval use in strict mode#12298

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-15-test_semantic_add_failing_tests_for_arguments_and_eval_use_in_strict_mode
Jul 16, 2025
Merged

test(semantic): add failing tests for arguments and eval use in strict mode#12298
graphite-app[bot] merged 1 commit intomainfrom
c/07-15-test_semantic_add_failing_tests_for_arguments_and_eval_use_in_strict_mode

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 15, 2025

No description provided.

Copy link
Contributor Author

camc314 commented Jul 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Jul 15, 2025
@Dunqing
Copy link
Member

Dunqing commented Jul 15, 2025

Should we add a pass test for your fixes?

@camc314
Copy link
Contributor Author

camc314 commented Jul 15, 2025

Should we add a pass test for your fixes?

oh i added these on each of the individual PRs

@Dunqing
Copy link
Member

Dunqing commented Jul 15, 2025

oh i added these on each of the individual PRs

Sorry, I didn't look back into these PRs. Do these tests already cover in the test262? If so, we don't need to add them.

@camc314
Copy link
Contributor Author

camc314 commented Jul 15, 2025

i don't think there are any tests for these specific cases. I've seen no diffs when running just coverage after these changes.

2a1e805#diff-e02a59350fc9a63236887ba2d5c4709cd3a93f39624ab66787e05892ab92c94b

were the only tests that cover this, but they don't go into the specificity of function args + destructureing ect

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Copy link
Member

Dunqing commented Jul 16, 2025

Merge activity

@camc314 camc314 force-pushed the c/07-15-test_semantic_add_failing_tests_for_arguments_and_eval_use_in_strict_mode branch from e7bd3ea to e7b8325 Compare July 16, 2025 07:40
@camc314 camc314 force-pushed the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch from 7100219 to cd4976e Compare July 16, 2025 07:40
@graphite-app graphite-app bot force-pushed the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch from cd4976e to 089f7b1 Compare July 16, 2025 07:50
@graphite-app graphite-app bot force-pushed the c/07-15-test_semantic_add_failing_tests_for_arguments_and_eval_use_in_strict_mode branch from e7b8325 to 6fa23ad Compare July 16, 2025 07:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Base automatically changed from c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration to main July 16, 2025 08:00
@graphite-app graphite-app bot merged commit 6fa23ad into main Jul 16, 2025
16 checks passed
@graphite-app graphite-app bot deleted the c/07-15-test_semantic_add_failing_tests_for_arguments_and_eval_use_in_strict_mode branch July 16, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants