test(semantic): add failing tests for arguments and eval use in strict mode#12298
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 16, 2025
Conversation
This was referenced Jul 15, 2025
Contributor
Author
Member
|
Should we add a |
Contributor
Author
oh i added these on each of the individual PRs |
Member
Sorry, I didn't look back into these PRs. Do these tests already cover in the |
Contributor
Author
|
i don't think there are any tests for these specific cases. I've seen no diffs when running 2a1e805#diff-e02a59350fc9a63236887ba2d5c4709cd3a93f39624ab66787e05892ab92c94b were the only tests that cover this, but they don't go into the specificity of function args + destructureing ect |
Dunqing
approved these changes
Jul 16, 2025
Member
Merge activity
|
e7bd3ea to
e7b8325
Compare
7100219 to
cd4976e
Compare
cd4976e to
089f7b1
Compare
e7b8325 to
6fa23ad
Compare
Base automatically changed from
c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration
to
main
July 16, 2025 08:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.