Skip to content

fix(semantic): allow arguments/eval as name of TSTypeAliasDeclaration, TSInterfaceDeclaration#12291

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration
Jul 16, 2025
Merged

fix(semantic): allow arguments/eval as name of TSTypeAliasDeclaration, TSInterfaceDeclaration#12291
graphite-app[bot] merged 1 commit intomainfrom
c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 15, 2025

this stack should fix #12286

Copy link
Contributor Author

camc314 commented Jul 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 changed the title fix(semantic): allow arguments as name of TSTypeAliasDeclaration, `TSInterfaceDeclaration fix(semantic): allow arguments/eval as name of TSTypeAliasDeclaration, `TSInterfaceDeclaration Jul 15, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2025

CodSpeed Instrumentation Performance Report

Merging #12291 will not alter performance

Comparing c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration (089f7b1) with main (3f33e8c)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot force-pushed the c/07-15-fix_semantic_allow_arguments_as_spread_argument_name_inside_tsmethodsignature_tsfunctiontype_ branch from ea6e978 to 435394b Compare July 15, 2025 12:38
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner July 15, 2025 12:38
@graphite-app graphite-app bot force-pushed the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch from aeff16e to abc9481 Compare July 15, 2025 12:38
@camc314 camc314 changed the title fix(semantic): allow arguments/eval as name of TSTypeAliasDeclaration, `TSInterfaceDeclaration fix(semantic): allow arguments/eval as name of TSTypeAliasDeclaration, TSInterfaceDeclaration Jul 15, 2025
@camc314 camc314 force-pushed the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch from abc9481 to 7100219 Compare July 15, 2025 14:01
@camc314 camc314 force-pushed the c/07-15-fix_semantic_allow_arguments_as_spread_argument_name_inside_tsmethodsignature_tsfunctiontype_ branch from 435394b to 1c0ebe2 Compare July 15, 2025 14:01
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
@graphite-app graphite-app bot changed the base branch from c/07-15-fix_semantic_allow_arguments_as_spread_argument_name_inside_tsmethodsignature_tsfunctiontype_ to graphite-base/12291 July 16, 2025 01:46
@camc314 camc314 force-pushed the graphite-base/12291 branch from 1c0ebe2 to 98fbca4 Compare July 16, 2025 07:40
@camc314 camc314 force-pushed the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch from 7100219 to cd4976e Compare July 16, 2025 07:40
@camc314 camc314 changed the base branch from graphite-base/12291 to c/07-15-fix_semantic_allow_arguments_as_spread_argument_name_inside_tsmethodsignature_tsfunctiontype_ July 16, 2025 07:40
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 16, 2025

Merge activity

…ation`, `TSInterfaceDeclaration` (#12291)

this stack should fix #12286
@graphite-app graphite-app bot force-pushed the c/07-15-fix_semantic_allow_arguments_as_spread_argument_name_inside_tsmethodsignature_tsfunctiontype_ branch from 98fbca4 to 1bfd44f Compare July 16, 2025 07:50
@graphite-app graphite-app bot force-pushed the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch from cd4976e to 089f7b1 Compare July 16, 2025 07:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Base automatically changed from c/07-15-fix_semantic_allow_arguments_as_spread_argument_name_inside_tsmethodsignature_tsfunctiontype_ to main July 16, 2025 07:58
@graphite-app graphite-app bot merged commit 089f7b1 into main Jul 16, 2025
25 checks passed
@graphite-app graphite-app bot deleted the c/07-15-fix_semantic_allow_arguments_as_name_of_tstypealiasdeclaration_tsinterfacedeclaration branch July 16, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

semantic: false positive with arguments usage in declaration files

2 participants